mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[PR #3148] [MERGED] fix: reduce the memory consumption during build to prevent OOM #4251
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4251
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/3148
Author: @NicklasWallgren
Created: 6/17/2023
Status: ✅ Merged
Merged: 7/17/2023
Merged by: @AndrewBastin
Base:
release/2023.4.8← Head:fix/hopescotch-selfhost-web-reduce-memory-usage-during-build📝 Commits (2)
912fbe0Reduce the memory consumption during build to prevent OOM in memory constraint environments.1d5b82fchore: update dockerignore to cleanly ignore node_modules📊 Changes
5 files changed (+9 additions, -4 deletions)
View changed files
➕
.dockerignore(+1 -0)📝
packages/hoppscotch-common/src/components.d.ts(+5 -1)📝
packages/hoppscotch-selfhost-web/Dockerfile(+1 -1)📝
packages/hoppscotch-selfhost-web/package.json(+1 -1)📝
packages/hoppscotch-sh-admin/Dockerfile(+1 -1)📄 Description
Closes #3146
Description
Reduces the max heap size from 16 GB (16384) to 4GB (4096) for Node V8 to prevent OOM in memory constraint environments.
This doesn't affect the build performance (to a large extent) according to my tests, the garbage collector might run a bit more frequently.
Checks
Additional Information
It might be a good idea to update the prerequisite documentation with a "minimum resource configuration" for docker desktop. The default docker desktop memory is limited to 2GB (and a swap of 1GB) which is to small to build the self-hosted web container.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.