[PR #3142] [MERGED] fix: shortcode resolution screen is stuck on invalid shortcodes #4247

Closed
opened 2026-03-17 01:48:06 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3142
Author: @nivedin
Created: 6/14/2023
Status: Merged
Merged: 6/19/2023
Merged by: @AndrewBastin

Base: release/2023.4.7Head: fix/shortcode-screen-stuck


📝 Commits (3)

  • e47b2d2 chore(ci): re-introduce hoppscotch-ui deploy script
  • ac42941 chore(ci): add manual workflow dispatch for hoppscotch-ui deploy script
  • 0c17021 fix: shortcode screen stuck when invalid link

📊 Changes

2 files changed (+55 additions, -0 deletions)

View changed files

.github/workflows/ui.yml (+42 -0)
📝 packages/hoppscotch-common/src/pages/r/_id.vue (+13 -0)

📄 Description

Closes HFE-106

Description

This PR fixes the issue where the shortcode resolution screen gets stuck when the link is invalid.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3142 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 6/14/2023 **Status:** ✅ Merged **Merged:** 6/19/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.4.7` ← **Head:** `fix/shortcode-screen-stuck` --- ### 📝 Commits (3) - [`e47b2d2`](https://github.com/hoppscotch/hoppscotch/commit/e47b2d2026629fa67532c2f37857cd8be3e3a1d3) chore(ci): re-introduce hoppscotch-ui deploy script - [`ac42941`](https://github.com/hoppscotch/hoppscotch/commit/ac42941ab42b8be07e7cb797f98f7894710c009a) chore(ci): add manual workflow dispatch for hoppscotch-ui deploy script - [`0c17021`](https://github.com/hoppscotch/hoppscotch/commit/0c170214bfda0fe92ad72a4a2bbb0558f4fd94ff) fix: shortcode screen stuck when invalid link ### 📊 Changes **2 files changed** (+55 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/ui.yml` (+42 -0) 📝 `packages/hoppscotch-common/src/pages/r/_id.vue` (+13 -0) </details> ### 📄 Description Closes HFE-106 ### Description This PR fixes the issue where the shortcode resolution screen gets stuck when the link is invalid. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:48:06 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4247
No description provided.