[PR #3130] [MERGED] fix: fix url getting overridden when query params are present #4244

New issue

Closed

opened 2026-03-17 01:47:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:47:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3130
Author: @amk-dev
Created: 6/9/2023
Status: ✅ Merged
Merged: 6/9/2023
Merged by: @AndrewBastin

Base: release/2023.4.6 ← Head: hfe-71

📝 Commits (1)

2676336 fix: fix url getting overridden when query params are present

📊 Changes

2 files changed (+18 additions, -8 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/RESTExtURLParams.ts (+14 -7)
📝 packages/hoppscotch-common/src/pages/index.vue (+4 -1)

📄 Description

fixes #3098
fixes HFE-71

Before

We support loading request properties from URL query params. we have a function translateExtURLParams that takes query params and converts it into Hoppscotch request properties, but this function was always adding these properties to the default request. so whenever a query param is present, this function is running, and it overwrites the existing request.

After

This function takes an optional initialRequest parameter that will be used instead of the defaultRequest if passed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3130 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 6/9/2023 **Status:** ✅ Merged **Merged:** 6/9/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.4.6` ← **Head:** `hfe-71` --- ### 📝 Commits (1) - [`2676336`](https://github.com/hoppscotch/hoppscotch/commit/26763368959b4650bcb45cb43fd8373b7724a48f) fix: fix url getting overridden when query params are present ### 📊 Changes **2 files changed** (+18 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/RESTExtURLParams.ts` (+14 -7) 📝 `packages/hoppscotch-common/src/pages/index.vue` (+4 -1) </details> ### 📄 Description fixes #3098 fixes HFE-71 **Before** We support loading request properties from URL query params. we have a function `translateExtURLParams` that takes query params and converts it into Hoppscotch request properties, but this function was always adding these properties to the default request. so whenever a query param is present, this function is running, and it overwrites the existing request. **After** This function takes an optional `initialRequest` parameter that will be used instead of the defaultRequest if passed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>