[PR #3137] [MERGED] fix: fixed issue with team-invitations and new user accounts #4241

New issue

Closed

opened 2026-03-17 01:47:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:47:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3137
Author: @balub
Created: 6/14/2023
Status: ✅ Merged
Merged: 6/15/2023
Merged by: @AndrewBastin

Base: release/2023.4.7 ← Head: fix/team-invitation-bug

📝 Commits (1)

363cd29 fix: fixed issue with team-invitations and new user accounts

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 packages/hoppscotch-backend/src/team-invitation/team-invite-viewer.guard.ts (+1 -1)
📝 packages/hoppscotch-backend/src/team-invitation/team-invitee.guard.ts (+1 -1)

📄 Description

Closes issue #3090

Description

This PR fixes a bug with the auth guards present in the TeamInvitation module where new users trying to join a team with a valid invitation could not do so and be presented with the BUG_AUTH_NO_USER_CTX error instead.

How to reproduce bug for testing

Have a normal running instance of SH running with one valid user account then:

Create a new team and Invite a new user whose account does not exist in the DB into the team.
Create the account for the user to whom you sent the invite link in the earlier step.
Make sure to be logged in as the newly created user click on the button in the email you received before to join the team.
You should see the error being thrown.

Issue Number

HBE-227

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

Nil

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3137 **Author:** [@balub](https://github.com/balub) **Created:** 6/14/2023 **Status:** ✅ Merged **Merged:** 6/15/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.4.7` ← **Head:** `fix/team-invitation-bug` --- ### 📝 Commits (1) - [`363cd29`](https://github.com/hoppscotch/hoppscotch/commit/363cd291f798d41306bda20593b2efbbbb0db2ed) fix: fixed issue with team-invitations and new user accounts ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/team-invitation/team-invite-viewer.guard.ts` (+1 -1) 📝 `packages/hoppscotch-backend/src/team-invitation/team-invitee.guard.ts` (+1 -1) </details> ### 📄 Description    Closes issue #3090 ### Description  This PR fixes a bug with the auth guards present in the TeamInvitation module where new users trying to join a team with a valid invitation could not do so and be presented with the *BUG_AUTH_NO_USER_CTX* error instead. ### How to reproduce bug for testing Have a normal running instance of SH running with one valid user account then: - Create a new team and Invite a new user whose account does not exist in the DB into the team. - Create the account for the user to whom you sent the invite link in the earlier step. - Make sure to be logged in as the newly created user click on the button in the email you received before to join the team. - You should see the error being thrown. ### Issue Number HBE-227 ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information  Nil --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>