[PR #3064] [MERGED] fix: analytics logging behavior being incorrect #4215

New issue

Closed

opened 2026-03-17 01:46:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:46:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3064
Author: @AndrewBastin
Created: 5/18/2023
Status: ✅ Merged
Merged: 5/23/2023
Merged by: @AndrewBastin

Base: release/2023.4.4 ← Head: fix/analytics-bugs

📝 Commits (2)

93cbf04 fix: onCodemirrorInstanceMount not called on certain places (HFE-49)
02fc32a fix: request run logging to analytics for rest not working (HFE-48)

📊 Changes

2 files changed (+10 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/http/Request.vue (+8 -0)
📝 packages/hoppscotch-common/src/composables/codemirror.ts (+2 -1)

📄 Description

Closes HFE-48
Closes HFE-49

Description

This pull request intends to fix some of the behaviors regarding analytics hooks which were not functioning to the defined contract.

onCodemirrorInstanceMount should be called everytime an editor instance is mounted into the DOM and also more times if the instance is removed from DOM and added again. Before, it was only called once.
logHoppRequestRunToAnalytics was not being called for REST Requests.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

To verify this, you can introduce a shim analytics object into the platform implementation and see if the required operations are being called properly for logging.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3064 **Author:** [@AndrewBastin](https://github.com/AndrewBastin) **Created:** 5/18/2023 **Status:** ✅ Merged **Merged:** 5/23/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.4.4` ← **Head:** `fix/analytics-bugs` --- ### 📝 Commits (2) - [`93cbf04`](https://github.com/hoppscotch/hoppscotch/commit/93cbf0425ae27c330e6bd0c0dd08d770736d00a8) fix: onCodemirrorInstanceMount not called on certain places (HFE-49) - [`02fc32a`](https://github.com/hoppscotch/hoppscotch/commit/02fc32a47c92033d46df37f1a08ff7aa38820864) fix: request run logging to analytics for rest not working (HFE-48) ### 📊 Changes **2 files changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/http/Request.vue` (+8 -0) 📝 `packages/hoppscotch-common/src/composables/codemirror.ts` (+2 -1) </details> ### 📄 Description Closes HFE-48 Closes HFE-49 ### Description This pull request intends to fix some of the behaviors regarding analytics hooks which were not functioning to the defined contract. - `onCodemirrorInstanceMount` should be called everytime an editor instance is mounted into the DOM and also more times if the instance is removed from DOM and added again. Before, it was only called once. - `logHoppRequestRunToAnalytics` was not being called for REST Requests. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information To verify this, you can introduce a shim `analytics` object into the platform implementation and see if the required operations are being called properly for logging. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>