[PR #3070] [MERGED] fix: timing dependency on test case #4211

New issue

Closed

opened 2026-03-17 01:46:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:46:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3070
Author: @mirarifhasan
Created: 5/22/2023
Status: ✅ Merged
Merged: 5/23/2023
Merged by: @AndrewBastin

Base: release/2023.4.4 ← Head: fix/user-history-test-case

📝 Commits (1)

46ac7e3 fix: timing dependency on test case

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-backend/src/user-history/user-history.service.spec.ts (+5 -3)

📄 Description

Closes HBE-194

Description

In this PR, we fix a unit test issue for the backend by which the build was being failed.

packages/hoppscotch-backend do-test:     - Expected Right  - 1
packages/hoppscotch-backend do-test:     + Received Right  + 1
packages/hoppscotch-backend do-test:       Object {
packages/hoppscotch-backend do-test:     -   "executedOn": 2023-04-23T10:19:35.258Z,
packages/hoppscotch-backend do-test:     +   "executedOn": 2023-04-23T10:19:35.257Z,
packages/hoppscotch-backend do-test:         "id": "1",
packages/hoppscotch-backend do-test:         "isStarred": false,
packages/hoppscotch-backend do-test:         "reqType": "REST",
packages/hoppscotch-backend do-test:         "request": "[{}]",
packages/hoppscotch-backend do-test:         "responseMetadata": "[{}]",
packages/hoppscotch-backend do-test:         "userUid": "abc",
packages/hoppscotch-backend do-test:       }

Here if you see, you will notice that the executedOn value is mismatched by a millisecond. This occurred because of we had written new Date() twice instead of using the same reference.

https://github.com/hoppscotch/hoppscotch/actions/runs/4777765956/jobs/8493727095

How to Reproduce Issue

Just run the backend test cases, sometime you will get this issue.

pnpm run test

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

Nil

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3070 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 5/22/2023 **Status:** ✅ Merged **Merged:** 5/23/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.4.4` ← **Head:** `fix/user-history-test-case` --- ### 📝 Commits (1) - [`46ac7e3`](https://github.com/hoppscotch/hoppscotch/commit/46ac7e3a16809788a90d225ed968e6276b888f13) fix: timing dependency on test case ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/user-history/user-history.service.spec.ts` (+5 -3) </details> ### 📄 Description    Closes HBE-194 ### Description  In this PR, we fix a unit test issue for the backend by which the build was being failed. ``` packages/hoppscotch-backend do-test: - Expected Right - 1 packages/hoppscotch-backend do-test: + Received Right + 1 packages/hoppscotch-backend do-test: Object { packages/hoppscotch-backend do-test: - "executedOn": 2023-04-23T10:19:35.258Z, packages/hoppscotch-backend do-test: + "executedOn": 2023-04-23T10:19:35.257Z, packages/hoppscotch-backend do-test: "id": "1", packages/hoppscotch-backend do-test: "isStarred": false, packages/hoppscotch-backend do-test: "reqType": "REST", packages/hoppscotch-backend do-test: "request": "[{}]", packages/hoppscotch-backend do-test: "responseMetadata": "[{}]", packages/hoppscotch-backend do-test: "userUid": "abc", packages/hoppscotch-backend do-test: } ``` Here if you see, you will notice that the `executedOn` value is mismatched by a millisecond. This occurred because of we had written `new Date()` twice instead of using the same reference. [https://github.com/hoppscotch/hoppscotch/actions/runs/4777765956/jobs/8493727095](https://github.com/hoppscotch/hoppscotch/actions/runs/4777765956/jobs/8493727095)  ### How to Reproduce Issue Just run the backend test cases, sometime you will get this issue. ``` pnpm run test ``` ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information  Nil --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>