[PR #3063] [MERGED] fix: sync popup firing multiple times #4207

Closed
opened 2026-03-17 01:45:55 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3063
Author: @nivedin
Created: 5/18/2023
Status: Merged
Merged: 5/31/2023
Merged by: @AndrewBastin

Base: release/2023.4.4Head: fix/sync-popup-bug


📝 Commits (2)

  • 2ea7f56 fix: sync popup fire multiple times
  • bda9ce6 fix: change name and remove watch

📊 Changes

2 files changed (+87 additions, -27 deletions)

View changed files

packages/hoppscotch-common/src/newstore/syncing.ts (+40 -0)
📝 packages/hoppscotch-common/src/pages/index.vue (+47 -27)

📄 Description

Closes HFE-46

Description

This PR fixes the issue where popup for workspace restoration was firing multiple times when navigating from other pages and returning back to the REST page and on some other occasions.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3063 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 5/18/2023 **Status:** ✅ Merged **Merged:** 5/31/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.4.4` ← **Head:** `fix/sync-popup-bug` --- ### 📝 Commits (2) - [`2ea7f56`](https://github.com/hoppscotch/hoppscotch/commit/2ea7f56c23d416fd12a91d8882adeaf43fcf2944) fix: sync popup fire multiple times - [`bda9ce6`](https://github.com/hoppscotch/hoppscotch/commit/bda9ce6dd8b210b8c315f60749b8a13bac426ac8) fix: change name and remove watch ### 📊 Changes **2 files changed** (+87 additions, -27 deletions) <details> <summary>View changed files</summary> ➕ `packages/hoppscotch-common/src/newstore/syncing.ts` (+40 -0) 📝 `packages/hoppscotch-common/src/pages/index.vue` (+47 -27) </details> ### 📄 Description Closes HFE-46 ### Description This PR fixes the issue where popup for workspace restoration was firing multiple times when navigating from other pages and returning back to the REST page and on some other occasions. ### Checks - [X] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [X] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:45:55 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4207
No description provided.