[PR #3025] [MERGED] fix: returning response from authCookieHandler #4190

New issue

Closed

opened 2026-03-17 01:44:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:44:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3025
Author: @mirarifhasan
Created: 5/2/2023
Status: ✅ Merged
Merged: 5/9/2023
Merged by: @AndrewBastin

Base: release/2023.4.2 ← Head: fix/cookie-handler

📝 Commits (1)

156c341 fix: re-returning response from authCookieHandler

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 packages/hoppscotch-backend/src/auth/helper.ts (+2 -2)

📄 Description

Issue number

Fixes #3024
Close HBE-191

Description

Background Information of Issue

So, whenever the {BASE_URL}/v1/auth/verify API was called, the response object was written with cookies. Afterward, the server sends a response to the client with conditional redirection. During sending the response, the backend service encounters the following error.

[Nest] 123  - 04/28/2023, 10:12:23 AM   ERROR [ExceptionsHandler] Cannot set headers after they are sent to the client
Error: Cannot set headers after they are sent to the client
    at new NodeError (node:internal/errors:393:5)
    at ServerResponse.setHeader (node:_http_outgoing:607:11)
    at ServerResponse.header (/usr/src/app/node_modules/.pnpm/express@4.18.2/node_modules/express/lib/response.js:794:10)
    at ServerResponse.location (/usr/src/app/node_modules/.pnpm/express@4.18.2/node_modules/express/lib/response.js:915:15)
    at ServerResponse.redirect (/usr/src/app/node_modules/.pnpm/express@4.18.2/node_modules/express/lib/response.js:953:18)
    at authCookieHandler (/usr/src/app/src/auth/helper.ts:75:29)
    at AuthController.verify (/usr/src/app/src/auth/auth.controller.ts:57:22)
    at /usr/src/app/node_modules/.pnpm/@nestjs+core@9.2.1_@nestjs+common@9.2.1_@nestjs+platform-express@9.2.1_reflect-metadata@0.1.13_rxjs@7.6.0/node_modules/@nestjs/core/router/router-execution-context.js:46:28
    at /usr/src/app/node_modules/.pnpm/@nestjs+core@9.2.1_@nestjs+common@9.2.1_@nestjs+platform-express@9.2.1_reflect-metadata@0.1.13_rxjs@7.6.0/node_modules/@nestjs/core/router/router-proxy.js:9:17

Proposed Solution

In the backend service, there were two statements for sending a response to the client (under conditional statement).
In the first statement, there were missed return keywords. For that reason, the response was sent to the client but further code execution is ongoing.
In the following code execution, there was another statement for sending the response to the client. As previously the response already sent to the client, the following one encountered the error.
Simply I added the return keyword to fix the issue.

return res.status(HttpStatus.OK).send();

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

Nil

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3025 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 5/2/2023 **Status:** ✅ Merged **Merged:** 5/9/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.4.2` ← **Head:** `fix/cookie-handler` --- ### 📝 Commits (1) - [`156c341`](https://github.com/hoppscotch/hoppscotch/commit/156c341a8114a9b692933a7f63d9713e90028b8a) fix: re-returning response from authCookieHandler ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/auth/helper.ts` (+2 -2) </details> ### 📄 Description   ### Issue number Fixes #3024 Close HBE-191 ### Description  #### Background Information of Issue So, whenever the `{BASE_URL}/v1/auth/verify` API was called, the `response` object was written with cookies. Afterward, the server sends a response to the client with conditional redirection. During sending the response, the backend service encounters the following error. ``` [Nest] 123 - 04/28/2023, 10:12:23 AM ERROR [ExceptionsHandler] Cannot set headers after they are sent to the client Error: Cannot set headers after they are sent to the client at new NodeError (node:internal/errors:393:5) at ServerResponse.setHeader (node:_http_outgoing:607:11) at ServerResponse.header (/usr/src/app/node_modules/.pnpm/express@4.18.2/node_modules/express/lib/response.js:794:10) at ServerResponse.location (/usr/src/app/node_modules/.pnpm/express@4.18.2/node_modules/express/lib/response.js:915:15) at ServerResponse.redirect (/usr/src/app/node_modules/.pnpm/express@4.18.2/node_modules/express/lib/response.js:953:18) at authCookieHandler (/usr/src/app/src/auth/helper.ts:75:29) at AuthController.verify (/usr/src/app/src/auth/auth.controller.ts:57:22) at /usr/src/app/node_modules/.pnpm/@nestjs+core@9.2.1_@nestjs+common@9.2.1_@nestjs+platform-express@9.2.1_reflect-metadata@0.1.13_rxjs@7.6.0/node_modules/@nestjs/core/router/router-execution-context.js:46:28 at /usr/src/app/node_modules/.pnpm/@nestjs+core@9.2.1_@nestjs+common@9.2.1_@nestjs+platform-express@9.2.1_reflect-metadata@0.1.13_rxjs@7.6.0/node_modules/@nestjs/core/router/router-proxy.js:9:17 ``` #### Proposed Solution In the backend service, there were two statements for sending a response to the client (under conditional statement). In the first statement, there were missed `return` keywords. For that reason, the response was sent to the client but further code execution is ongoing. In the following code execution, there was another statement for sending the response to the client. As previously the response already sent to the client, the following one encountered the error. Simply I added the `return` keyword to fix the issue. ``` return res.status(HttpStatus.OK).send(); ```  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information  Nil --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>