mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #3013] [MERGED] feat: scroll to show the new active tab header #4189
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4189
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/3013
Author: @anwarulislam
Created: 4/21/2023
Status: ✅ Merged
Merged: 5/9/2023
Merged by: @AndrewBastin
Base:
release/2023.4.2← Head:feat/scroll-to-new-active-tab-header📝 Commits (4)
759fdc2feat: scroll to show the new active tab header77ac32efix: scrollbar position issue8eda0fechore: updated by native scrolling api with intersection observer16663dechore: improve tab active styles📊 Changes
1 file changed (+95 additions, -25 deletions)
View changed files
📝
packages/hoppscotch-ui/src/components/smart/Windows.vue(+95 -25)📄 Description
Description
Improved the tab head section. When a tab selection is updated automatically (like when we click on a request in a collection which has a tab open or we click on add new tab button), the tab headers section should scroll to show the new active tab header.
Walkthrough
nextTickfunction fromvueto manipulate scroll position of tab container based on active tab ID (link, link)TAB_WIDTHconstant to calculate tab container width and tab position (link)watcheffect to monitor changes ofmodelValueprop and scroll to active tab if needed (link)🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
postinstallscript #4716