[PR #3012] [MERGED] fix: wrong tab selected after navigating from different route #4187

Closed
opened 2026-03-17 01:44:49 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3012
Author: @anwarulislam
Created: 4/21/2023
Status: Merged
Merged: 4/23/2023
Merged by: @AndrewBastin

Base: mainHead: fix/selected-tab-incremental-issue


📝 Commits (1)

  • 54925d6 fix: wrong tab selected after navigating from different route

📊 Changes

1 file changed (+0 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-ui/src/components/smart/Windows.vue (+0 -3)

📄 Description

Description

Issue: If multiple tabs are opened, and the first tab is selected. after going to another page from the REST page and then coming back to REST, the selection goes to the next tab.

Previously, we were forcefully selecting the first possible Window forcefully after removing any active Window. And it was happening onBeforeUnmounted. But, now it will select the last Window automatically.

  • Not Completed
  • Completed

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3012 **Author:** [@anwarulislam](https://github.com/anwarulislam) **Created:** 4/21/2023 **Status:** ✅ Merged **Merged:** 4/23/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `fix/selected-tab-incremental-issue` --- ### 📝 Commits (1) - [`54925d6`](https://github.com/hoppscotch/hoppscotch/commit/54925d6d6458817de4be9e13bcb6f49e55aaa734) fix: wrong tab selected after navigating from different route ### 📊 Changes **1 file changed** (+0 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-ui/src/components/smart/Windows.vue` (+0 -3) </details> ### 📄 Description ### Description Issue: If multiple tabs are opened, and the first tab is selected. after going to another page from the REST page and then coming back to REST, the selection goes to the next tab. Previously, we were forcefully selecting the first possible `Window` forcefully after removing any active `Window`. And it was happening `onBeforeUnmounted`. But, now it will select the last `Window` automatically. - [ ] Not Completed - [x] Completed ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:44:49 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4187
No description provided.