[PR #3028] [MERGED] fix: magic link URL #4186

New issue

Closed

opened 2026-03-17 01:44:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:44:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3028
Author: @mirarifhasan
Created: 5/3/2023
Status: ✅ Merged
Merged: 5/9/2023
Merged by: @AndrewBastin

Base: release/2023.4.2 ← Head: fix/magic-link

📝 Commits (1)

aab52a1 fix: url of the magic link

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-backend/src/auth/auth.service.ts (+1 -1)

📄 Description

Issue Number

Fixes #3016
Closes HBE-195

Description

Background Information of Issue

During the Sign In with the magic-link option, the user gets an email with a link (embedded with a token).
The path/route of the magic link was mismatched with the front-end application. For that reason, users are getting 404 error in the front-end application and are unable to sign in to the application successfully.

Proposed Solution

In this PR, we fixed the magic link (path/route), which was sent through email. After this fix, the user will be able to sign in to the application successfully.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

Nil

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3028 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 5/3/2023 **Status:** ✅ Merged **Merged:** 5/9/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.4.2` ← **Head:** `fix/magic-link` --- ### 📝 Commits (1) - [`aab52a1`](https://github.com/hoppscotch/hoppscotch/commit/aab52a1fdb9a7f3d7509cc6099d50a3a3c63a410) fix: url of the magic link ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/auth/auth.service.ts` (+1 -1) </details> ### 📄 Description    ### Issue Number Fixes #3016 Closes HBE-195 ### Description  #### Background Information of Issue During the *Sign In* with the magic-link option, the user gets an email with a link (embedded with a token). The path/route of the magic link was mismatched with the front-end application. For that reason, users are getting 404 error in the front-end application and are unable to sign in to the application successfully. <img width="1438" alt="Screenshot 2023-05-04 at 2 06 37 PM" src="https://user-images.githubusercontent.com/30154643/236146155-d81d1f8a-2c98-4ca9-9789-a8904928e5bb.png"> #### Proposed Solution In this PR, we fixed the magic link (path/route), which was sent through email. After this fix, the user will be able to sign in to the application successfully.  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information  Nil --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>