mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #3002] [MERGED] fix: selected env changed while sidebar collapsed #4184
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4184
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/3002
Author: @nivedin
Created: 4/18/2023
Status: ✅ Merged
Merged: 4/21/2023
Merged by: @AndrewBastin
Base:
main← Head:fix/env-change-sidebar-collapse📝 Commits (5)
fdb4707fix: selected env changed while sidebar collapsedd5cb21echore: used ?? instead of ||2721f54fix: backward compatibility check745c296chore: remove unwanted code6d0e27erefactor: set localstorage rather setting store📊 Changes
3 files changed (+62 additions, -26 deletions)
View changed files
📝
packages/hoppscotch-common/src/components.d.ts(+31 -0)📝
packages/hoppscotch-common/src/components/environments/index.vue(+0 -2)📝
packages/hoppscotch-common/src/newstore/localpersistence.ts(+31 -24)📄 Description
Closes #2995
Description
This PR resolves the problem where, when a user selects a team environment and toggles the sidebar, the selected environment is reset.
Checks
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
@db.Timestamptz(3)and removeluxondependency #5137