[PR #3002] [MERGED] fix: selected env changed while sidebar collapsed #4184

Closed
opened 2026-03-17 01:44:33 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3002
Author: @nivedin
Created: 4/18/2023
Status: Merged
Merged: 4/21/2023
Merged by: @AndrewBastin

Base: mainHead: fix/env-change-sidebar-collapse


📝 Commits (5)

  • fdb4707 fix: selected env changed while sidebar collapsed
  • d5cb21e chore: used ?? instead of ||
  • 2721f54 fix: backward compatibility check
  • 745c296 chore: remove unwanted code
  • 6d0e27e refactor: set localstorage rather setting store

📊 Changes

3 files changed (+62 additions, -26 deletions)

View changed files

📝 packages/hoppscotch-common/src/components.d.ts (+31 -0)
📝 packages/hoppscotch-common/src/components/environments/index.vue (+0 -2)
📝 packages/hoppscotch-common/src/newstore/localpersistence.ts (+31 -24)

📄 Description

Closes #2995

Description

This PR resolves the problem where, when a user selects a team environment and toggles the sidebar, the selected environment is reset.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3002 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 4/18/2023 **Status:** ✅ Merged **Merged:** 4/21/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `fix/env-change-sidebar-collapse` --- ### 📝 Commits (5) - [`fdb4707`](https://github.com/hoppscotch/hoppscotch/commit/fdb4707d3fd9377778f88e43cb064ef57c1f6655) fix: selected env changed while sidebar collapsed - [`d5cb21e`](https://github.com/hoppscotch/hoppscotch/commit/d5cb21e583b94ff098231b90de9c12088f9ec14e) chore: used ?? instead of || - [`2721f54`](https://github.com/hoppscotch/hoppscotch/commit/2721f54c6c84ed511f09cb89e26d558e6907f8be) fix: backward compatibility check - [`745c296`](https://github.com/hoppscotch/hoppscotch/commit/745c29671898ce781ce6ad2b6e5b0561914ed209) chore: remove unwanted code - [`6d0e27e`](https://github.com/hoppscotch/hoppscotch/commit/6d0e27e3e3b678cabc5ffde6bce68feebba73ab8) refactor: set localstorage rather setting store ### 📊 Changes **3 files changed** (+62 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components.d.ts` (+31 -0) 📝 `packages/hoppscotch-common/src/components/environments/index.vue` (+0 -2) 📝 `packages/hoppscotch-common/src/newstore/localpersistence.ts` (+31 -24) </details> ### 📄 Description Closes #2995 ### Description This PR resolves the problem where, when a user selects a team environment and toggles the sidebar, the selected environment is reset. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:44:33 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4184
No description provided.