[PR #2974] [MERGED] refactor: add optional ids to environments #4167

New issue

Closed

opened 2026-03-17 01:43:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:43:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2974
Author: @amk-dev
Created: 4/8/2023
Status: ✅ Merged
Merged: 4/9/2023
Merged by: @AndrewBastin

Base: staging ← Head: refactor/add-ids-to-env-store

📝 Commits (2)

2c86d1b feat: add id field to Environment
d6788a9 fix: do not explicitly use undefined for id

📊 Changes

5 files changed (+98 additions, -12 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/environments/my/Details.vue (+15 -1)
📝 packages/hoppscotch-common/src/components/environments/my/Environment.vue (+3 -2)
📝 packages/hoppscotch-common/src/helpers/RequestRunner.ts (+1 -1)
📝 packages/hoppscotch-common/src/newstore/environments.ts (+78 -8)
📝 packages/hoppscotch-data/src/environment.ts (+1 -0)

📄 Description

Before

The env store didn't have ids for environments, this created challenges when syncing these changes to the backend.

After

This PR adds ids to the environments store, so hoppscotch platform can use ids for syncing if needed. also this change is kept backward compatible.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2974 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 4/8/2023 **Status:** ✅ Merged **Merged:** 4/9/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `staging` ← **Head:** `refactor/add-ids-to-env-store` --- ### 📝 Commits (2) - [`2c86d1b`](https://github.com/hoppscotch/hoppscotch/commit/2c86d1b4e5f6da6b8ed9c84d24a10424dfbda250) feat: add id field to Environment - [`d6788a9`](https://github.com/hoppscotch/hoppscotch/commit/d6788a99da03904ac0f44b4de0b0de5bc493b408) fix: do not explicitly use undefined for id ### 📊 Changes **5 files changed** (+98 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/environments/my/Details.vue` (+15 -1) 📝 `packages/hoppscotch-common/src/components/environments/my/Environment.vue` (+3 -2) 📝 `packages/hoppscotch-common/src/helpers/RequestRunner.ts` (+1 -1) 📝 `packages/hoppscotch-common/src/newstore/environments.ts` (+78 -8) 📝 `packages/hoppscotch-data/src/environment.ts` (+1 -0) </details> ### 📄 Description **Before** The env store didn't have ids for environments, this created challenges when syncing these changes to the backend. **After** This PR adds ids to the environments store, so hoppscotch platform can use ids for syncing if needed. also this change is kept backward compatible. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>