[PR #2967] [MERGED] fix: reordering last request bug and its UX #4164

New issue

Closed

opened 2026-03-17 01:43:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:43:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2967
Author: @nivedin
Created: 4/5/2023
Status: ✅ Merged
Merged: 4/5/2023
Merged by: @AndrewBastin

Base: staging ← Head: fix/reorder-last-request

📝 Commits (7)

62058d5 fix: tabhead and scrolling issue (#2966)
f91d40b fix: reorder last request bug
a22a8b6 fix: disable move to same location
c72740f chore: reset drag state after drop
ecb17cd chore: remove ctc ordering state reset
cf8a97a chore: disable reordering when only 1 item exists
4168066 fix: convert compute to method

📊 Changes

10 files changed (+261 additions, -141 deletions)

View changed files

📝 packages/hoppscotch-common/src/components.d.ts (+2 -1)
📝 packages/hoppscotch-common/src/components/collections/Collection.vue (+10 -4)
📝 packages/hoppscotch-common/src/components/collections/MyCollections.vue (+41 -39)
📝 packages/hoppscotch-common/src/components/collections/TeamCollections.vue (+49 -47)
📝 packages/hoppscotch-common/src/components/collections/index.vue (+34 -2)
📝 packages/hoppscotch-common/src/pages/index.vue (+23 -9)
📝 packages/hoppscotch-ui/.prettierrc.cjs (+0 -0)
📝 packages/hoppscotch-ui/package.json (+1 -0)
📝 packages/hoppscotch-ui/src/components/smart/Window.vue (+20 -11)
📝 packages/hoppscotch-ui/src/components/smart/Windows.vue (+81 -28)

📄 Description

Description

This PR fixes the issue when reordering a request to the bottom of its list throws an error in some cases. This PR also improves UX while reordering.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2967 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 4/5/2023 **Status:** ✅ Merged **Merged:** 4/5/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `staging` ← **Head:** `fix/reorder-last-request` --- ### 📝 Commits (7) - [`62058d5`](https://github.com/hoppscotch/hoppscotch/commit/62058d5dfef959a9d329f957bc2d44345da52865) fix: tabhead and scrolling issue (#2966) - [`f91d40b`](https://github.com/hoppscotch/hoppscotch/commit/f91d40b063af6f6c80c03a3f0ce3a0be40a9c90b) fix: reorder last request bug - [`a22a8b6`](https://github.com/hoppscotch/hoppscotch/commit/a22a8b652c78d4ee8c0e3f89166b0d84b0ec4510) fix: disable move to same location - [`c72740f`](https://github.com/hoppscotch/hoppscotch/commit/c72740fffc5aad66d5a17a8d5a8db200dd244a83) chore: reset drag state after drop - [`ecb17cd`](https://github.com/hoppscotch/hoppscotch/commit/ecb17cd19d39ebd1eb9ff2aa15129d1ba92a4a02) chore: remove ctc ordering state reset - [`cf8a97a`](https://github.com/hoppscotch/hoppscotch/commit/cf8a97a1cd57bf45c58d47719baa88cfc0e84141) chore: disable reordering when only 1 item exists - [`4168066`](https://github.com/hoppscotch/hoppscotch/commit/41680665785ba398d7826203ea57890706dd2659) fix: convert compute to method ### 📊 Changes **10 files changed** (+261 additions, -141 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components.d.ts` (+2 -1) 📝 `packages/hoppscotch-common/src/components/collections/Collection.vue` (+10 -4) 📝 `packages/hoppscotch-common/src/components/collections/MyCollections.vue` (+41 -39) 📝 `packages/hoppscotch-common/src/components/collections/TeamCollections.vue` (+49 -47) 📝 `packages/hoppscotch-common/src/components/collections/index.vue` (+34 -2) 📝 `packages/hoppscotch-common/src/pages/index.vue` (+23 -9) 📝 `packages/hoppscotch-ui/.prettierrc.cjs` (+0 -0) 📝 `packages/hoppscotch-ui/package.json` (+1 -0) 📝 `packages/hoppscotch-ui/src/components/smart/Window.vue` (+20 -11) 📝 `packages/hoppscotch-ui/src/components/smart/Windows.vue` (+81 -28) </details> ### 📄 Description ### Description This PR fixes the issue when reordering a request to the bottom of its list throws an error in some cases. This PR also improves UX while reordering. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>