[PR #2963] [MERGED] chore: load terms of service & privacy policy links from env variables #4160

Closed
opened 2026-03-17 01:43:11 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2963
Author: @amk-dev
Created: 4/4/2023
Status: Merged
Merged: 4/4/2023
Merged by: @AndrewBastin

Base: stagingHead: chore/toc-pp-links-to-env


📝 Commits (2)

  • dd72eac fix: no page rendering issue after navigating from rest page (#2962)
  • f4329bd chore: load terms of service & privacy policy links from env

📊 Changes

4 files changed (+71 additions, -58 deletions)

View changed files

📝 .env.example (+4 -0)
📝 packages/hoppscotch-common/src/components/collections/index.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/firebase/Login.vue (+11 -3)
📝 packages/hoppscotch-common/src/pages/index.vue (+55 -54)

📄 Description

Before

Terms Of Service and Privacy Policy links where hardcoded

After

Terms Of Service and Privacy Policy links are now loaded from env variables. they're optional. and if they're not provided, the TOS and Privacy Policy text are not rendered.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2963 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 4/4/2023 **Status:** ✅ Merged **Merged:** 4/4/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `staging` ← **Head:** `chore/toc-pp-links-to-env` --- ### 📝 Commits (2) - [`dd72eac`](https://github.com/hoppscotch/hoppscotch/commit/dd72eacd2171c0d9c651d0b51420b4fe4507eaa1) fix: no page rendering issue after navigating from rest page (#2962) - [`f4329bd`](https://github.com/hoppscotch/hoppscotch/commit/f4329bdd9cab44bd6fe47b1b5991f5496a484ee4) chore: load terms of service & privacy policy links from env ### 📊 Changes **4 files changed** (+71 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+4 -0) 📝 `packages/hoppscotch-common/src/components/collections/index.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/firebase/Login.vue` (+11 -3) 📝 `packages/hoppscotch-common/src/pages/index.vue` (+55 -54) </details> ### 📄 Description **Before** Terms Of Service and Privacy Policy links where hardcoded **After** Terms Of Service and Privacy Policy links are now loaded from env variables. they're optional. and if they're not provided, the TOS and Privacy Policy text are not rendered. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:43:11 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4160
No description provided.