[PR #2953] [MERGED] chore: move settings firebase things to platform #4153

New issue

Closed

opened 2026-03-17 01:42:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:42:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2953
Author: @amk-dev
Created: 3/28/2023
Status: ✅ Merged
Merged: 3/29/2023
Merged by: @AndrewBastin

Base: staging ← Head: feat/hoppscotch-web-settings

📝 Commits (1)

aae2869 chore: move settings firebase things to platform

📊 Changes

5 files changed (+116 additions, -2 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/fb/index.ts (+1 -2)
📝 packages/hoppscotch-common/src/platform/index.ts (+2 -0)
➕ packages/hoppscotch-common/src/platform/settings.ts (+3 -0)
📝 packages/hoppscotch-web/src/main.ts (+2 -0)
➕ packages/hoppscotch-web/src/settings.ts (+108 -0)

📄 Description

This PR extracts out the settings firebase syncing to hoppscotch-web, and defines the common interface to be used with other hoppscotch platforms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2953 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 3/28/2023 **Status:** ✅ Merged **Merged:** 3/29/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `staging` ← **Head:** `feat/hoppscotch-web-settings` --- ### 📝 Commits (1) - [`aae2869`](https://github.com/hoppscotch/hoppscotch/commit/aae28692025e73dcb934363694aa817084d0b9aa) chore: move settings firebase things to platform ### 📊 Changes **5 files changed** (+116 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/fb/index.ts` (+1 -2) 📝 `packages/hoppscotch-common/src/platform/index.ts` (+2 -0) ➕ `packages/hoppscotch-common/src/platform/settings.ts` (+3 -0) 📝 `packages/hoppscotch-web/src/main.ts` (+2 -0) ➕ `packages/hoppscotch-web/src/settings.ts` (+108 -0) </details> ### 📄 Description This PR extracts out the settings firebase syncing to hoppscotch-web, and defines the common interface to be used with other hoppscotch platforms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>