[PR #2952] [MERGED] refactor: make editFolder, editCollection take Partial collection as parameter #4152

New issue

Closed

opened 2026-03-17 01:42:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:42:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2952
Author: @amk-dev
Created: 3/27/2023
Status: ✅ Merged
Merged: 3/29/2023
Merged by: @AndrewBastin

Base: staging ← Head: chore/gql-store-changes

📝 Commits (2)

3b4c587 refactor: make editFolder, editCollection take Partial collection
dafe8a9 fix: fix adding reactive objects for editCollections

📊 Changes

1 file changed (+22 additions, -10 deletions)

View changed files

📝 packages/hoppscotch-common/src/newstore/collections.ts (+22 -10)

📄 Description

before:

editCollection, editFolder dispatchers needed the entire collection to make an edit. this was not ideal when we want to update small part of the collection.

after:

now editFolder and editCollection accepts a partial collection and folder object and merges it with the collection. this is also backward compatible, so no code changes to existing system are needed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2952 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 3/27/2023 **Status:** ✅ Merged **Merged:** 3/29/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `staging` ← **Head:** `chore/gql-store-changes` --- ### 📝 Commits (2) - [`3b4c587`](https://github.com/hoppscotch/hoppscotch/commit/3b4c587cc34d462ffcc38df2fc4072b6bdfd4c3d) refactor: make editFolder, editCollection take Partial collection - [`dafe8a9`](https://github.com/hoppscotch/hoppscotch/commit/dafe8a9069b2c5415cb607e7ab586c0a0c464e02) fix: fix adding reactive objects for editCollections ### 📊 Changes **1 file changed** (+22 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/newstore/collections.ts` (+22 -10) </details> ### 📄 Description before: editCollection, editFolder dispatchers needed the entire collection to make an edit. this was not ideal when we want to update small part of the collection. after: now editFolder and editCollection accepts a partial collection and folder object and merges it with the collection. this is also backward compatible, so no code changes to existing system are needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>