mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[PR #2927] [MERGED] refactor: update hopp-ui to be independent #4142
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4142
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/2927
Author: @AndrewBastin
Created: 2/21/2023
Status: ✅ Merged
Merged: 2/24/2023
Merged by: @AndrewBastin
Base:
main← Head:refactor/hopp-ui-isolate📝 Commits (9)
669aba3refactor: update hopp-ui to be independent795db1bfeat: introduce story for HoppSmartExpand96172b8refactor: update packaging and move hoppscotch-common usage to have hopp prefixa7cd573chore: make hoppscotch-ui more friendly to typescript2971a0dchore: move to vuedraggable-es and uncomment Windows.vue export4ac7179chore: unnecessary classes removed4ea3044Merge branch 'refactor/hopp-ui-isolate' of github.com:AndrewBastin/hoppscotch into pr/AndrewBastin/292738eb63achore: remove unnecessary classes33af3f2chore: revert windicss classes📊 Changes
165 files changed (+2041 additions, -1976 deletions)
View changed files
📝
packages/hoppscotch-common/package.json(+1 -1)📝
packages/hoppscotch-common/src/App.vue(+1 -1)📝
packages/hoppscotch-common/src/components.d.ts(+10 -28)📝
packages/hoppscotch-common/src/components/app/DeveloperOptions.vue(+3 -3)📝
packages/hoppscotch-common/src/components/app/Footer.vue(+21 -21)📝
packages/hoppscotch-common/src/components/app/Header.vue(+9 -9)📝
packages/hoppscotch-common/src/components/app/Interceptor.vue(+6 -3)📝
packages/hoppscotch-common/src/components/app/Options.vue(+14 -14)📝
packages/hoppscotch-common/src/components/app/PowerSearch.vue(+2 -2)📝
packages/hoppscotch-common/src/components/app/Share.vue(+2 -2)📝
packages/hoppscotch-common/src/components/app/Shortcuts.vue(+2 -2)📝
packages/hoppscotch-common/src/components/app/ShortcutsPrompt.vue(+1 -1)📝
packages/hoppscotch-common/src/components/app/Sidenav.vue(+2 -2)📝
packages/hoppscotch-common/src/components/app/Support.vue(+9 -9)📝
packages/hoppscotch-common/src/components/collections/Add.vue(+4 -4)📝
packages/hoppscotch-common/src/components/collections/AddFolder.vue(+4 -4)📝
packages/hoppscotch-common/src/components/collections/AddRequest.vue(+4 -4)📝
packages/hoppscotch-common/src/components/collections/Collection.vue(+8 -8)📝
packages/hoppscotch-common/src/components/collections/Edit.vue(+4 -4)📝
packages/hoppscotch-common/src/components/collections/EditFolder.vue(+4 -4)...and 80 more files
📄 Description
This PR aims to allow
hoppscotch-uipackage to be properly independent and be easily installed onto any Vue SPA project which will later come down the line.With the new updates you will be able to integrate
hoppscotch-uiby just adding it to dependencies, and then following this:Along with that, all the components in
hoppscotch-uiare now prefixed with aHoppprefix. For e.g,ButtonPrimary->HoppButtonPrimary. To facilitate this,hoppscotch-web's Vite config defines a resolver forunplugin-vue-componentsto resolve any component query starting withHoppto be resolved from@hoppscotch/ui.There are some concerns about whether the ESM module tree-shaking and code splitting is working properly and if the necessary code can be spliced up properly. This will be verified and benchmarked in the coming days.
Checks
Additional Information
N/A
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.