[PR #2891] [MERGED] fix: login modal not visible in small screen #4121

New issue

Closed

opened 2026-03-17 01:41:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:41:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2891
Author: @anwarulislam
Created: 12/25/2022
Status: ✅ Merged
Merged: 12/26/2022
Merged by: @liyasthomas

Base: main ← Head: bug/small-screen-login-modal

📝 Commits (1)

51e4058 fix: login modal not visible in small screen

📊 Changes

4 files changed (+32 additions, -22 deletions)

View changed files

📝 packages/hoppscotch-common/src/components.d.ts (+1 -0)
➕ packages/hoppscotch-common/src/components/app/ActionHandler.vue (+26 -0)
📝 packages/hoppscotch-common/src/components/app/Footer.vue (+4 -22)
📝 packages/hoppscotch-common/src/layouts/default.vue (+1 -0)

📄 Description

Closes #2890

Description

This PR resolves the issue where the login panel was not visible on phone screens. The issue was addressed by moving all modals from the Footer component to a new component called ActionHandler, which contains the defineActionHandler functions. This new component was then imported into the default layout component, ensuring that it will be rendered on all devices.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2891 **Author:** [@anwarulislam](https://github.com/anwarulislam) **Created:** 12/25/2022 **Status:** ✅ Merged **Merged:** 12/26/2022 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `main` ← **Head:** `bug/small-screen-login-modal` --- ### 📝 Commits (1) - [`51e4058`](https://github.com/hoppscotch/hoppscotch/commit/51e40581b01b7f1a5b8fe3a91fb8e0a3e8382459) fix: login modal not visible in small screen ### 📊 Changes **4 files changed** (+32 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components.d.ts` (+1 -0) ➕ `packages/hoppscotch-common/src/components/app/ActionHandler.vue` (+26 -0) 📝 `packages/hoppscotch-common/src/components/app/Footer.vue` (+4 -22) 📝 `packages/hoppscotch-common/src/layouts/default.vue` (+1 -0) </details> ### 📄 Description  Closes #2890  ### Description This PR resolves the issue where the login panel was not visible on phone screens. The issue was addressed by moving all modals from the `Footer` component to a new component called `ActionHandler`, which contains the `defineActionHandler` functions. This new component was then imported into the `default` layout component, ensuring that it will be rendered on all devices.  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>