[PR #2874] [MERGED] chore: reintroduce sitemap generation #4120

Closed
opened 2026-03-17 01:40:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2874
Author: @AndrewBastin
Created: 12/10/2022
Status: Merged
Merged: 12/11/2022
Merged by: @AndrewBastin

Base: mainHead: chore/sitemap


📝 Commits (2)

  • efa2283 chore: reintroduce sitemap generation
  • e46a7e5 Merge branch 'main' into chore/sitemap

📊 Changes

5 files changed (+40 additions, -13 deletions)

View changed files

📝 packages/hoppscotch-common/src/components.d.ts (+1 -3)
📝 packages/hoppscotch-web/.gitignore (+3 -0)
📝 packages/hoppscotch-web/package.json (+1 -0)
📝 packages/hoppscotch-web/vite.config.ts (+20 -10)
📝 pnpm-lock.yaml (+15 -0)

📄 Description

Description/Before

With the migration to the split common packages (3d004f2322), we found out that the generateSitemap functionality was not working properly and was difficult to get it working properly within the merge timeframe. Hence, we deferred the implementation to later. This PR re-introduces sitemap and robots file generation.

After

  • Introduce vite-plugin-static-copy as a dependency to copy generated sitemap files from 'hoppscotch-web/.sitemap-gen' folder.
  • generateSitemap reintroduced with a small typescript hack because of this issue: https://github.com/jbaubree/vite-plugin-pages-sitemap/issues/173
  • During build time, vite-plugin-pages-sitemap is now configured to generate sitemap.xml and robots.txt in hoppscotch-web/.sitemap-gen (later copied at the end of the build process to dist by vite-plugin-static-copy).
  • Added .sitemap-gen to .gitignore for hoppscotch-web

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2874 **Author:** [@AndrewBastin](https://github.com/AndrewBastin) **Created:** 12/10/2022 **Status:** ✅ Merged **Merged:** 12/11/2022 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `chore/sitemap` --- ### 📝 Commits (2) - [`efa2283`](https://github.com/hoppscotch/hoppscotch/commit/efa2283d5923c904dce3e67f72655f24386086df) chore: reintroduce sitemap generation - [`e46a7e5`](https://github.com/hoppscotch/hoppscotch/commit/e46a7e5c0429a6e35650ae1ba30aee805efed9f5) Merge branch 'main' into chore/sitemap ### 📊 Changes **5 files changed** (+40 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components.d.ts` (+1 -3) 📝 `packages/hoppscotch-web/.gitignore` (+3 -0) 📝 `packages/hoppscotch-web/package.json` (+1 -0) 📝 `packages/hoppscotch-web/vite.config.ts` (+20 -10) 📝 `pnpm-lock.yaml` (+15 -0) </details> ### 📄 Description ### Description/Before With the migration to the split common packages (3d004f2322018ab00837fd0caa86e13ef5ec2123), we found out that the `generateSitemap` functionality was not working properly and was difficult to get it working properly within the merge timeframe. Hence, we deferred the implementation to later. This PR re-introduces sitemap and robots file generation. ## After - Introduce `vite-plugin-static-copy` as a dependency to copy generated sitemap files from 'hoppscotch-web/.sitemap-gen' folder. - `generateSitemap` reintroduced with a small typescript hack because of this issue: https://github.com/jbaubree/vite-plugin-pages-sitemap/issues/173 - During build time, `vite-plugin-pages-sitemap` is now configured to generate `sitemap.xml` and `robots.txt` in `hoppscotch-web/.sitemap-gen` (later copied at the end of the build process to `dist` by `vite-plugin-static-copy`). - Added `.sitemap-gen` to `.gitignore` for `hoppscotch-web` ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [ ] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:40:59 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4120
No description provided.