[PR #2873] [MERGED] fix: cannot write to body when a request is loaded from history #4116

New issue

Closed

opened 2026-03-17 01:40:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:40:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2873
Author: @amk-dev
Created: 12/9/2022
Status: ✅ Merged
Merged: 12/9/2022
Merged by: @liyasthomas

Base: staging ← Head: fix/cannot-write-to-body

📝 Commits (2)

3093e2c fix: cannot write body when a request is loaded from history
88a1afe fix: import toRaw() from vue

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/history/index.vue (+2 -2)

📄 Description

Before

After Loading a request from user's hoppscotch history, changes to the request body where not taking effect. this is happening, because we are calling setRequest with a computed property, which is readonly.

After

We pass the computed property as a normal object to setRequest which fixes the issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2873 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 12/9/2022 **Status:** ✅ Merged **Merged:** 12/9/2022 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `staging` ← **Head:** `fix/cannot-write-to-body` --- ### 📝 Commits (2) - [`3093e2c`](https://github.com/hoppscotch/hoppscotch/commit/3093e2cb5a16ceb9d51b0206864481943a295037) fix: cannot write body when a request is loaded from history - [`88a1afe`](https://github.com/hoppscotch/hoppscotch/commit/88a1afe3365edc7e3ba0b62465d05b2af46e6bef) fix: import `toRaw()` from vue ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/history/index.vue` (+2 -2) </details> ### 📄 Description **Before** After Loading a request from user's hoppscotch history, changes to the request body where not taking effect. this is happening, because we are calling `setRequest` with a computed property, which is readonly. **After** We pass the computed property as a normal object to `setRequest` which fixes the issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>