[PR #2861] [MERGED] fix: delete not working properly on request body #4111

Closed
opened 2026-03-17 01:40:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2861
Author: @amk-dev
Created: 11/24/2022
Status: Merged
Merged: 11/25/2022
Merged by: @AndrewBastin

Base: mainHead: fix/form-parameters-not-deleted


📝 Commits (1)

  • 42a7926 fix: fix workingParams watcher not triggering

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-app/src/components/http/BodyParameters.vue (+3 -1)

📄 Description

fixes #2859

Before

See the mentioned issue for more info.

we were using Array.splice to remove an element from an array. but this was not triggering a watcher on the array.

After

we now use Array.filter to remove an element from an array and the reactivity works


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2861 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 11/24/2022 **Status:** ✅ Merged **Merged:** 11/25/2022 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `fix/form-parameters-not-deleted` --- ### 📝 Commits (1) - [`42a7926`](https://github.com/hoppscotch/hoppscotch/commit/42a7926fdcfd691071b8e75be9b146186595b428) fix: fix workingParams watcher not triggering ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/src/components/http/BodyParameters.vue` (+3 -1) </details> ### 📄 Description fixes #2859 **Before** See the mentioned issue for more info. we were using ```Array.splice``` to remove an element from an array. but this was not triggering a watcher on the array. **After** we now use ```Array.filter``` to remove an element from an array and the reactivity works --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:40:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4111
No description provided.