mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #2777] [MERGED] chore: remove brands translations #4058
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4058
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/2777
Author: @DanielKrasny
Created: 10/11/2022
Status: ✅ Merged
Merged: 10/12/2022
Merged by: @liyasthomas
Base:
i18n← Head:main📝 Commits (3)
744c4e4chore: remove brands translations73c3f92Merge branch 'main' into main882d5f0Merge branch 'main' into main📊 Changes
9 files changed (+11 additions, -11 deletions)
View changed files
📝
packages/hoppscotch-app/locales/ar.json(+1 -1)📝
packages/hoppscotch-app/locales/cs.json(+1 -1)📝
packages/hoppscotch-app/locales/el.json(+1 -1)📝
packages/hoppscotch-app/locales/fi.json(+1 -1)📝
packages/hoppscotch-app/locales/he.json(+1 -1)📝
packages/hoppscotch-app/locales/hi.json(+3 -3)📝
packages/hoppscotch-app/locales/ko.json(+1 -1)📝
packages/hoppscotch-app/locales/ru.json(+1 -1)📝
packages/hoppscotch-app/locales/sr.json(+1 -1)📄 Description
Description
I believe brands (or social networks in this case) should not be translated even though some languages are not using the Latin alphabet. This PR replaces all translations of GitHub, Discord and/or Twitter.
Checks
Additional Information
My inspiration came from Twitter Help Center. Feel free to test any language, but Twitter (brand name) remains without a change.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.