[PR #2742] [MERGED] fix: fix type error when generating profile picture initials #4032

Closed
opened 2026-03-17 01:35:54 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2742
Author: @amk-dev
Created: 10/6/2022
Status: Merged
Merged: 10/6/2022
Merged by: @AndrewBastin

Base: mainHead: sentry/HOPPSCOTCH-APP-30


📝 Commits (5)

  • 5d8baea fix: add checks and defaults for display name
  • 3bf22fb fix: add user-icon to profile picture when displayName and picture url is not present
  • 02258df fix: make typescript happy
  • 0c12659 chore: use i18n
  • d2ec5ac chore: rename translation tag for a more descriptive name

📊 Changes

4 files changed (+25 additions, -9 deletions)

View changed files

📝 packages/hoppscotch-app/locales/en.json (+2 -1)
📝 packages/hoppscotch-app/src/components/app/Header.vue (+12 -3)
📝 packages/hoppscotch-app/src/components/profile/Picture.vue (+8 -4)
📝 packages/hoppscotch-app/src/pages/profile.vue (+3 -1)

📄 Description

Description

fixes HOPPSCOTCH-APP-30

fixes #2745


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2742 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 10/6/2022 **Status:** ✅ Merged **Merged:** 10/6/2022 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `sentry/HOPPSCOTCH-APP-30` --- ### 📝 Commits (5) - [`5d8baea`](https://github.com/hoppscotch/hoppscotch/commit/5d8baeae7e74a6a0b5e0f844c319a3445ddb06a5) fix: add checks and defaults for display name - [`3bf22fb`](https://github.com/hoppscotch/hoppscotch/commit/3bf22fb569a2d58ba2d5cfb27f22e1e227abf3a7) fix: add user-icon to profile picture when displayName and picture url is not present - [`02258df`](https://github.com/hoppscotch/hoppscotch/commit/02258df6bad4da973cb31be1deac8c5912f7419e) fix: make typescript happy - [`0c12659`](https://github.com/hoppscotch/hoppscotch/commit/0c12659a6d0ec807574895e1d12ac945988e0642) chore: use i18n - [`d2ec5ac`](https://github.com/hoppscotch/hoppscotch/commit/d2ec5ac8a684e7566f2ec1df2b6261d07505b4d7) chore: rename translation tag for a more descriptive name ### 📊 Changes **4 files changed** (+25 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/locales/en.json` (+2 -1) 📝 `packages/hoppscotch-app/src/components/app/Header.vue` (+12 -3) 📝 `packages/hoppscotch-app/src/components/profile/Picture.vue` (+8 -4) 📝 `packages/hoppscotch-app/src/pages/profile.vue` (+3 -1) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> ### Description <!-- Add a brief description of the pull request --> fixes HOPPSCOTCH-APP-30 fixes #2745 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:35:54 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4032
No description provided.