mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[PR #2742] [MERGED] fix: fix type error when generating profile picture initials #4032
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4032
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/2742
Author: @amk-dev
Created: 10/6/2022
Status: ✅ Merged
Merged: 10/6/2022
Merged by: @AndrewBastin
Base:
main← Head:sentry/HOPPSCOTCH-APP-30📝 Commits (5)
5d8baeafix: add checks and defaults for display name3bf22fbfix: add user-icon to profile picture when displayName and picture url is not present02258dffix: make typescript happy0c12659chore: use i18nd2ec5acchore: rename translation tag for a more descriptive name📊 Changes
4 files changed (+25 additions, -9 deletions)
View changed files
📝
packages/hoppscotch-app/locales/en.json(+2 -1)📝
packages/hoppscotch-app/src/components/app/Header.vue(+12 -3)📝
packages/hoppscotch-app/src/components/profile/Picture.vue(+8 -4)📝
packages/hoppscotch-app/src/pages/profile.vue(+3 -1)📄 Description
Description
fixes HOPPSCOTCH-APP-30
fixes #2745
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.