mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[PR #2719] [MERGED] ci: modify publish-docker workflow to push for ARM platforms #4019
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4019
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/2719
Author: @piraces
Created: 10/1/2022
Status: ✅ Merged
Merged: 10/1/2022
Merged by: @liyasthomas
Base:
main← Head:feat/multi-arch-docker-image📝 Commits (1)
39f2e28ci: modify publish-docker workflow to push for arm📊 Changes
1 file changed (+10 additions, -3 deletions)
View changed files
📝
.github/workflows/publish-docker.yml(+10 -3)📄 Description
Closes #2524
Description
This PR modifies the
publish-docker.ymlworkflow in order to publish the docker image for ARM based platforms.Now it pushes images for the following platforms:
This will add support for new Apple computers with M-series chips, and newer Raspberry Pi (among other systems as well).
Checks
Additional Information
As the original base image
node:lts-slimsupports the platforms linux/amd64, linux/arm/v7 and linux/arm64/v8, we can build for those platforms too without problem.The workflow modifications are based on the docker/build-push-action docs for Multi-platform image. I have added two steps to setup QEMU and buildx as the docs indicate (in order to have support for multiple platforms and be able to build multi-platform images, accordingly).
I have tested and run the workflow in my fork publishing to Docker Hub here. There you can test if you want the current branch (I have been testing with QEMU by myself).
As you can see in Docker Hub multiple platforms are now listed (in my part). This is the expected result when this PR gets merged and then making a release.
The only con of this approach (but inevitable), is that the
Build and push Docker imagetakes about 20min instead of 5 minutes as now... but this is due to building for two newer platforms with QEMU.Note: I have also modified the reference for some actions in the workflow to target the latest version of the action, instead of a fixed commit (I see this more stable than a fixed commit that can be older). Nevertheless, if this is a problem I can go back and make a commit reference.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.