[PR #2679] [CLOSED] fix: parse env with dash from request body #3990

Closed
opened 2026-03-17 01:33:27 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2679
Author: @anwarulislam
Created: 9/19/2022
Status: Closed

Base: mainHead: bug/env-dash-in-request-body


📝 Commits (1)

  • acfe579 fix: parse env with dash from request body

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 packages/hoppscotch-app/src/helpers/utils/EffectiveURL.ts (+3 -2)

📄 Description

Closes #2665

Description

When I use an env variable with a dash in its name in a JSON body, the variable does not become substituted with the actual value. Even though the variable is correctly highlighted green. With this PR this issue get resolved.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2679 **Author:** [@anwarulislam](https://github.com/anwarulislam) **Created:** 9/19/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bug/env-dash-in-request-body` --- ### 📝 Commits (1) - [`acfe579`](https://github.com/hoppscotch/hoppscotch/commit/acfe579f686650ab83e065501409e478e0a66c7a) fix: parse env with dash from request body ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/src/helpers/utils/EffectiveURL.ts` (+3 -2) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes #2665 <!-- Issue # here --> ### Description When I use an env variable with a dash in its name in a JSON body, the variable does not become substituted with the actual value. Even though the variable is correctly highlighted green. With this PR this issue get resolved. <!-- Add a brief description of the pull request --> <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:33:27 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#3990
No description provided.