[PR #2626] [MERGED] fix: link github and google #3947

New issue

Closed

opened 2026-03-17 01:31:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:31:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2626
Author: @aitchnyu
Created: 8/31/2022
Status: ✅ Merged
Merged: 9/6/2022
Merged by: @AndrewBastin

Base: main ← Head: fix/link-multiple-accounts

📝 Commits (1)

c726cc7 fix: link github and google

📊 Changes

2 files changed (+21 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-app/components/firebase/Login.vue (+2 -3)
📝 packages/hoppscotch-app/helpers/fb/auth.ts (+19 -0)

📄 Description

Closes #2610

Description

This fixes the original bug report in #2610 about having a Github and Google account. They were not getting linked previously. This is a draft PR to request inputs about how to handle multiple combinations of accounts.

For example sign in with Google assumes linked account is always Github. Sign in with Github assumes linked account is Google. Sign in with Microsoft assumes linked account is Github. We should allow any combination of linked accounts and our code should reflect that.

Don't know about Github/MS/Google to email behavior.

This could be an opportunity to DRY some duplicate code.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2626 **Author:** [@aitchnyu](https://github.com/aitchnyu) **Created:** 8/31/2022 **Status:** ✅ Merged **Merged:** 9/6/2022 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `fix/link-multiple-accounts` --- ### 📝 Commits (1) - [`c726cc7`](https://github.com/hoppscotch/hoppscotch/commit/c726cc70785ef289e61d9c46ec9cf014b5b03e6c) fix: link github and google ### 📊 Changes **2 files changed** (+21 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/components/firebase/Login.vue` (+2 -3) 📝 `packages/hoppscotch-app/helpers/fb/auth.ts` (+19 -0) </details> ### 📄 Description   Closes #2610 ### Description This fixes the original bug report in #2610 about having a Github and Google account. They were not getting linked previously. This is a draft PR to request inputs about how to handle multiple combinations of accounts. For example sign in with Google assumes linked account is always Github. Sign in with Github assumes linked account is Google. Sign in with Microsoft assumes linked account is Github. We should allow any combination of linked accounts and our code should reflect that. Don't know about Github/MS/Google to email behavior. This could be an opportunity to DRY some duplicate code.  ### Checks  - [ ] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [ ] All the tests have passed ### Additional Information  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>