[PR #2454] [MERGED] fix: environment variables save without pressing 'save' button #3823

New issue

Closed

opened 2026-03-17 01:24:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:24:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2454
Author: @nivedin
Created: 6/23/2022
Status: ✅ Merged
Merged: 6/30/2022
Merged by: @AndrewBastin

Base: main ← Head: fix/env-save-bug

📝 Commits (5)

117baf9 fix: environment variable saved without pressing save button
609c121 chore: add type for env variable
99631be fix: env variable type fix
8845570 refactor: filter out variables without a key value
ad56cf8 refactor: simplify envExpandError logic

📊 Changes

1 file changed (+60 additions, -18 deletions)

View changed files

📝 packages/hoppscotch-app/components/environments/Details.vue (+60 -18)

📄 Description

Closes #2436

Description

This PR fixes a bug that saved the environment variables without pressing the 'save' button.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2454 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 6/23/2022 **Status:** ✅ Merged **Merged:** 6/30/2022 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `fix/env-save-bug` --- ### 📝 Commits (5) - [`117baf9`](https://github.com/hoppscotch/hoppscotch/commit/117baf9d19c2e44fa207586976612ba374613a8f) fix: environment variable saved without pressing save button - [`609c121`](https://github.com/hoppscotch/hoppscotch/commit/609c121e2bb558faa0dc018ffd706baa504979c9) chore: add type for env variable - [`99631be`](https://github.com/hoppscotch/hoppscotch/commit/99631be34f85b10defc5ea713d4b41dd30dc0efe) fix: env variable type fix - [`8845570`](https://github.com/hoppscotch/hoppscotch/commit/8845570846f328045df1da5d5f9375a9af1bed43) refactor: filter out variables without a key value - [`ad56cf8`](https://github.com/hoppscotch/hoppscotch/commit/ad56cf865f8a830c162742679610e9b70957d5fd) refactor: simplify envExpandError logic ### 📊 Changes **1 file changed** (+60 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/components/environments/Details.vue` (+60 -18) </details> ### 📄 Description Closes #2436 ### Description This PR fixes a bug that saved the environment variables without pressing the 'save' button. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>