[PR #2428] [MERGED] fix: resolve removing body parameters in requests (#2390) #3809

New issue

Closed

opened 2026-03-17 01:23:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:23:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2428
Author: @vaugenwake
Created: 6/15/2022
Status: ✅ Merged
Merged: 6/16/2022
Merged by: @AndrewBastin

Base: main ← Head: fix-remove-body-parameter

📝 Commits (2)

1df08b5 fix: resolve removing body parameters in requests (#2390)
dd66a23 refactor: instead of adding id to FormData, add a wrapper object with ID

📊 Changes

1 file changed (+85 additions, -45 deletions)

View changed files

📝 packages/hoppscotch-app/components/http/BodyParameters.vue (+85 -45)

📄 Description

Closes #2390

Description

This PR resolves an issue with removing a parameters for request body parameters causing the browser to crash and hang. The solution to this is to add an id parameter to parameters so that each item is unique in the view and gets re-rendered on change.

[x] Fixed removing a body parameter from REST Request

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2428 **Author:** [@vaugenwake](https://github.com/vaugenwake) **Created:** 6/15/2022 **Status:** ✅ Merged **Merged:** 6/16/2022 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `fix-remove-body-parameter` --- ### 📝 Commits (2) - [`1df08b5`](https://github.com/hoppscotch/hoppscotch/commit/1df08b5e143094aa32c54f0b536255583c1d8361) fix: resolve removing body parameters in requests (#2390) - [`dd66a23`](https://github.com/hoppscotch/hoppscotch/commit/dd66a23e75730d37432e7a4e421f06a896f02d8d) refactor: instead of adding id to FormData, add a wrapper object with ID ### 📊 Changes **1 file changed** (+85 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/components/http/BodyParameters.vue` (+85 -45) </details> ### 📄 Description   Closes #2390 ### Description This PR resolves an issue with removing a parameters for request body parameters causing the browser to crash and hang. The solution to this is to add an `id` parameter to parameters so that each item is unique in the view and gets re-rendered on change. [x] Fixed removing a body parameter from REST Request ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>