mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #2425] [MERGED] feat: display response size with a bigger unit in tooltip #3801
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#3801
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/2425
Author: @nicognaW
Created: 6/13/2022
Status: ✅ Merged
Merged: 6/14/2022
Merged by: @AndrewBastin
Base:
main← Head:response-size-tooltip📝 Commits (4)
880b542feat: display response size with a bigger unit in tooltipd7bb8f9refactor: optimize and fix response size hint.d562195refactor: display readable response size text in the span and raw text in the tooltip.1714d6echore: rename responseSizeReadable and add doc comments📊 Changes
1 file changed (+37 additions, -2 deletions)
View changed files
📝
packages/hoppscotch-app/components/http/ResponseMeta.vue(+37 -2)📄 Description
Description
The response size is always displayed using larger units like KB or MB in other API testing tools I've used. But hoppscotch shows them up with only a B. I added a tooltip to display the response size in reasonable units.
For responses with a size of 0b to 1000b, the tooltip won't show up. For those with a size of 1000b to 1000000b, kB will be shown. For those larger than 1000000b, mb will be shown.
I am no expert on the front-end technologies, so I just imitated the current codes. If you don't like these codes, please keep the idea even if you close the pr.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.