[GH-ISSUE #1078] Externalise properties of deletion messages #379

Closed
opened 2026-03-16 14:58:22 +03:00 by kerem · 4 comments
Owner

Originally created by @joelcamus on GitHub (Aug 15, 2020).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/1078

Originally assigned to: @joelcamus on GitHub.

The message is static, I think that is a good idea, I send a language file. en-US.json, es-ES.json ...

imagen

removeCollection() {
      if (!confirm("Are you sure you want to remove this Collection?")) return
      this.$store.commit("postwoman/removeCollection", {
        collectionIndex: this.collectionIndex,
      })
      this.syncCollections()
    },

The same happened in other collections, folders, requests and environments.

New developments:

  • Collection
  • Folder
  • Request
  • Environment
Originally created by @joelcamus on GitHub (Aug 15, 2020). Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/1078 Originally assigned to: @joelcamus on GitHub. The message is static, I think that is a good idea, I send a language file. `en-US.json, es-ES.json ...` ![imagen](https://user-images.githubusercontent.com/8535654/90312708-dedc5180-df06-11ea-9688-670386763f5a.png) ```javascript removeCollection() { if (!confirm("Are you sure you want to remove this Collection?")) return this.$store.commit("postwoman/removeCollection", { collectionIndex: this.collectionIndex, }) this.syncCollections() }, ``` The same happened in other collections, folders, requests and environments. New developments: - [x] Collection - [x] Folder - [x] Request - [x] Environment
kerem 2026-03-16 14:58:22 +03:00
Author
Owner

@liyasthomas commented on GitHub (Aug 15, 2020):

Good observation. Assigning this to you - hoping for a PR soon.

<!-- gh-comment-id:674397305 --> @liyasthomas commented on GitHub (Aug 15, 2020): Good observation. Assigning this to you - hoping for a PR soon.
Author
Owner

@joelcamus commented on GitHub (Aug 15, 2020):

Done PR 👌

<!-- gh-comment-id:674405461 --> @joelcamus commented on GitHub (Aug 15, 2020): Done PR :ok_hand:
Author
Owner

@liyasthomas commented on GitHub (Aug 15, 2020):

Will get to it in a jiffy.

<!-- gh-comment-id:674405641 --> @liyasthomas commented on GitHub (Aug 15, 2020): Will get to it in a jiffy.
Author
Owner

@liyasthomas commented on GitHub (Aug 15, 2020):

Fixed in #1079

<!-- gh-comment-id:674408612 --> @liyasthomas commented on GitHub (Aug 15, 2020): Fixed in #1079
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#379
No description provided.