[PR #2332] [MERGED] feat: extension identification improvements #3741

Closed
opened 2026-03-17 01:19:51 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2332
Author: @amk-dev
Created: 5/10/2022
Status: Merged
Merged: 5/19/2022
Merged by: @AndrewBastin

Base: mainHead: feat/extension-improvements


📝 Commits (10+)

  • 06554d2 feat: add a proxy for communicating with the extension
  • 301da78 feat: add proxy logic to mounted hook
  • 7d2f3a1 refactor: remove polling for extension changes
  • 195b39c refactor: remove as
  • 22c5a34 feat: make identification backward compactible
  • 2f8adc5 Merge branch 'main' into feat/extension-improvements
  • f25b545 fix: replace usePolled with setInterval
  • 4133575 fix: check for undefined extension hooks
  • 78b8d96 fix: add type HoppExtensionStatusHook
  • 80d7f8b refactor: make type name uppercase

📊 Changes

10 files changed (+243 additions, -129 deletions)

View changed files

📝 packages/hoppscotch-app/components/app/Interceptor.vue (+33 -54)
📝 packages/hoppscotch-app/components/smart/Radio.vue (+20 -22)
📝 packages/hoppscotch-app/components/smart/RadioGroup.vue (+8 -4)
📝 packages/hoppscotch-app/helpers/strategies/ExtensionStrategy.ts (+50 -12)
📝 packages/hoppscotch-app/helpers/strategies/__tests__/ExtensionStrategy-NoProxy.spec.js (+0 -7)
📝 packages/hoppscotch-app/layouts/default.vue (+66 -0)
packages/hoppscotch-app/newstore/HoppExtension.ts (+40 -0)
📝 packages/hoppscotch-app/pages/settings.vue (+14 -26)
📝 packages/hoppscotch-app/types/pw-ext-hook.d.ts (+9 -0)
📝 packages/hoppscotch-app/types/window.d.ts (+3 -4)

📄 Description

  • feat: add a proxy for communicating with the extension
  • feat: add proxy logic to mounted hook

Closes #2176

Description

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

Requires hoppscotch/hoppscotch-extension#136 to be merged


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2332 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 5/10/2022 **Status:** ✅ Merged **Merged:** 5/19/2022 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `feat/extension-improvements` --- ### 📝 Commits (10+) - [`06554d2`](https://github.com/hoppscotch/hoppscotch/commit/06554d27eaf4f5252b90f4663249e575efdaf2c4) feat: add a proxy for communicating with the extension - [`301da78`](https://github.com/hoppscotch/hoppscotch/commit/301da784204d9f035c0857331da399c679b92b5c) feat: add proxy logic to mounted hook - [`7d2f3a1`](https://github.com/hoppscotch/hoppscotch/commit/7d2f3a1f21586ff6b0efa348675a439eea4db385) refactor: remove polling for extension changes - [`195b39c`](https://github.com/hoppscotch/hoppscotch/commit/195b39cefda8245dcba997b29f1ed560c39357c4) refactor: remove as - [`22c5a34`](https://github.com/hoppscotch/hoppscotch/commit/22c5a34bf86f941bd6b4c4fc25eef8ccf141218f) feat: make identification backward compactible - [`2f8adc5`](https://github.com/hoppscotch/hoppscotch/commit/2f8adc5d711e019c8b4f11f280b571fd53edaf7d) Merge branch 'main' into feat/extension-improvements - [`f25b545`](https://github.com/hoppscotch/hoppscotch/commit/f25b54560003f30ff52b98c431be2a313c88dab8) fix: replace usePolled with setInterval - [`4133575`](https://github.com/hoppscotch/hoppscotch/commit/41335752ef7920a2d94d11a27b100967ccf147c5) fix: check for undefined extension hooks - [`78b8d96`](https://github.com/hoppscotch/hoppscotch/commit/78b8d9692f412381d3f232c3f27f14573c0db265) fix: add type HoppExtensionStatusHook - [`80d7f8b`](https://github.com/hoppscotch/hoppscotch/commit/80d7f8b28732773580bf51471a8963f70994ce30) refactor: make type name uppercase ### 📊 Changes **10 files changed** (+243 additions, -129 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/components/app/Interceptor.vue` (+33 -54) 📝 `packages/hoppscotch-app/components/smart/Radio.vue` (+20 -22) 📝 `packages/hoppscotch-app/components/smart/RadioGroup.vue` (+8 -4) 📝 `packages/hoppscotch-app/helpers/strategies/ExtensionStrategy.ts` (+50 -12) 📝 `packages/hoppscotch-app/helpers/strategies/__tests__/ExtensionStrategy-NoProxy.spec.js` (+0 -7) 📝 `packages/hoppscotch-app/layouts/default.vue` (+66 -0) ➕ `packages/hoppscotch-app/newstore/HoppExtension.ts` (+40 -0) 📝 `packages/hoppscotch-app/pages/settings.vue` (+14 -26) 📝 `packages/hoppscotch-app/types/pw-ext-hook.d.ts` (+9 -0) 📝 `packages/hoppscotch-app/types/window.d.ts` (+3 -4) </details> ### 📄 Description - feat: add a proxy for communicating with the extension - feat: add proxy logic to mounted hook <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes #2176 <!-- Issue # here --> ### Description <!-- Add a brief description of the pull request --> <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [x] My code requires changes to the documentation - [x] I have updated the documentation as required - [x] All the tests have passed ### Additional Information <!-- Any additional information like breaking changes, dependencies added, screenshots, comparisons between new and old behavior, etc. --> Requires hoppscotch/hoppscotch-extension#136 to be merged --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:19:51 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#3741
No description provided.