mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[GH-ISSUE #1067] URL bar shows red border when an environment variable is being used #374
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#374
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xaddict on GitHub (Aug 11, 2020).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/1067
Originally assigned to: @liyasthomas on GitHub.
Describe the bug
When you fill in an environment variable in the URL ("<<base_url>>/products") the URL input field shows a red border as if something is wrong.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
If Postwoman does variable checking the border should be like the default state if the resulting URL is valid.
If it does not check the variables' content, the border should be default if there is any variable in it.
If postwoman doesn't check for variables in the URL field at all, the border should always be default since there's no way to find out if the URL is valid.
Screenshots

Desktop (please complete the following information):
@liyasthomas commented on GitHub (Aug 11, 2020):
Hiya - I tried to repoduce this behaviour in windows 10, Chrome latest. There seems to be no issue in this setup, will try out in macOS later get back to you.
@liyasthomas commented on GitHub (Aug 17, 2020):
@NBTX can you reproduce this issue in above configs?
@joelcamus commented on GitHub (Aug 17, 2020):
I try in Firefox and I replicate a bug, With Chromo I don't replicate the bug
Windows 10
Browser Firefox Developer 80.0b8
Windows 10
Browser Firefox 79.0 (64-bit)
@joelcamus commented on GitHub (Aug 17, 2020):
I look for and I think it's a problem, I change
type="url"fortype="text"github.com/hoppscotch/hoppscotch@629ee3e33f/pages/index.vue (L144-L156)@liyasthomas commented on GitHub (Aug 17, 2020):
If
type='text'then no issues?@joelcamus commented on GitHub (Aug 17, 2020):
Yes, it works
@liyasthomas commented on GitHub (Aug 17, 2020):
Fixed
@joelcamus commented on GitHub (Aug 18, 2020):
LGTM