[PR #2324] [MERGED] fix : save request popup bug #3731

New issue

Closed

opened 2026-03-17 01:19:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:19:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2324
Author: @nivedin
Created: 5/5/2022
Status: ✅ Merged
Merged: 5/5/2022
Merged by: @AndrewBastin

Base: main ← Head: fix/save-request-popup

📝 Commits (2)

5c53bcd fix: fixed the popup to trigger when the request has been already saved
b9ef805 refactor: change context when saving

📊 Changes

2 files changed (+20 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-app/components/collections/SaveRequest.vue (+6 -0)
📝 packages/hoppscotch-app/components/http/Request.vue (+14 -1)

📄 Description

Closes #2318

Description

This PR fixes the unsaved change popup bug in which the popup tends to trigger even though the request was saved.PR also fix a small bug that occurred when changing context while saving the request.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2324 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 5/5/2022 **Status:** ✅ Merged **Merged:** 5/5/2022 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `fix/save-request-popup` --- ### 📝 Commits (2) - [`5c53bcd`](https://github.com/hoppscotch/hoppscotch/commit/5c53bcdeebf44f57815cc3d490215c8c398fa8cc) fix: fixed the popup to trigger when the request has been already saved - [`b9ef805`](https://github.com/hoppscotch/hoppscotch/commit/b9ef805feeda3fa65f5c402007758e8b4cbc0487) refactor: change context when saving ### 📊 Changes **2 files changed** (+20 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/components/collections/SaveRequest.vue` (+6 -0) 📝 `packages/hoppscotch-app/components/http/Request.vue` (+14 -1) </details> ### 📄 Description Closes #2318 ### Description This PR fixes the unsaved change popup bug in which the popup tends to trigger even though the request was saved.PR also fix a small bug that occurred when changing context while saving the request. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>