[PR #2270] [MERGED] fix: add aria labels to forms #3696

Closed
opened 2026-03-17 01:17:24 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2270
Author: @sweetkane
Created: 4/17/2022
Status: Merged
Merged: 4/18/2022
Merged by: @liyasthomas

Base: mainHead: main


📝 Commits (1)

  • b43fad8 fix: add aria labels to forms

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 packages/hoppscotch-app/components/smart/EnvInput.vue (+1 -0)

📄 Description

Closes #2137

Description

Add code to make all forms on page have an aria label equivelent to their placeholder text. This fix works as long as forms have descriptive placeholder text. There may still be more screen reader accessibility improvements to make in the future, but it looks like every component is properly labeled for screen reader use at the moment.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

Google Lighthouse accessibility rating before change

Lighthouse pre

Google Lighthouse accessibility rating after change

Lighthouse post


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2270 **Author:** [@sweetkane](https://github.com/sweetkane) **Created:** 4/17/2022 **Status:** ✅ Merged **Merged:** 4/18/2022 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`b43fad8`](https://github.com/hoppscotch/hoppscotch/commit/b43fad88e5125869f3bc3632f77ef5269e46a78d) fix: add aria labels to forms ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/components/smart/EnvInput.vue` (+1 -0) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes #2137 ### Description Add code to make all forms on page have an aria label equivelent to their placeholder text. This fix works as long as forms have descriptive placeholder text. There may still be more screen reader accessibility improvements to make in the future, but it looks like every component is properly labeled for screen reader use at the moment. ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information #### Google Lighthouse accessibility rating before change ![Lighthouse pre](https://user-images.githubusercontent.com/71854758/163727212-4113141b-d312-4d5e-bee0-0f4aa7236554.png) #### Google Lighthouse accessibility rating after change ![Lighthouse post](https://user-images.githubusercontent.com/71854758/163727210-06496ca7-97cb-4130-958d-76abde41195a.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:17:24 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#3696
No description provided.