mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #2270] [MERGED] fix: add aria labels to forms #3696
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#3696
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/2270
Author: @sweetkane
Created: 4/17/2022
Status: ✅ Merged
Merged: 4/18/2022
Merged by: @liyasthomas
Base:
main← Head:main📝 Commits (1)
b43fad8fix: add aria labels to forms📊 Changes
1 file changed (+1 additions, -0 deletions)
View changed files
📝
packages/hoppscotch-app/components/smart/EnvInput.vue(+1 -0)📄 Description
Closes #2137
Description
Add code to make all forms on page have an aria label equivelent to their placeholder text. This fix works as long as forms have descriptive placeholder text. There may still be more screen reader accessibility improvements to make in the future, but it looks like every component is properly labeled for screen reader use at the moment.
Checks
Additional Information
Google Lighthouse accessibility rating before change
Google Lighthouse accessibility rating after change
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.