[PR #2268] [MERGED] feat: loading states for modal buttons #3693

New issue

Closed

opened 2026-03-17 01:17:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:17:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2268
Author: @kyteinsky
Created: 4/16/2022
Status: ✅ Merged
Merged: 4/20/2022
Merged by: @AndrewBastin

Base: main ← Head: feat/loading-states

📝 Commits (8)

2b5a3a6 feat: add loading state to CollectionsAdd modal
e388eb4 feat: add loading state to CollectionsEdit modal
fe194e3 feat: add loading state to CollectionsAddFolder modal
bb30e3d feat: add loading state to CollectionsEditFolder modal
d1b7637 feat: add loading state to CollectionsEditRequest modal
695764f feat: add loading state to collection deletion
7632655 feat: add loading state to request deletion
0f0cf31 feat: add loading state to folder deletion and other fixes

📊 Changes

13 files changed (+242 additions, -177 deletions)

View changed files

📝 packages/hoppscotch-app/components/collections/Add.vue (+2 -1)
📝 packages/hoppscotch-app/components/collections/AddFolder.vue (+6 -2)
📝 packages/hoppscotch-app/components/collections/Edit.vue (+2 -1)
📝 packages/hoppscotch-app/components/collections/EditFolder.vue (+6 -2)
📝 packages/hoppscotch-app/components/collections/EditRequest.vue (+6 -2)
📝 packages/hoppscotch-app/components/collections/index.vue (+184 -33)
📝 packages/hoppscotch-app/components/collections/my/Collection.vue (+2 -9)
📝 packages/hoppscotch-app/components/collections/my/Folder.vue (+9 -39)
📝 packages/hoppscotch-app/components/collections/my/Request.vue (+1 -12)
📝 packages/hoppscotch-app/components/collections/teams/Collection.vue (+4 -18)
📝 packages/hoppscotch-app/components/collections/teams/Folder.vue (+8 -43)
📝 packages/hoppscotch-app/components/collections/teams/Request.vue (+3 -12)
📝 packages/hoppscotch-app/components/smart/ConfirmModal.vue (+9 -3)

📄 Description

Description

Adds loading state to buttons in different modals.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2268 **Author:** [@kyteinsky](https://github.com/kyteinsky) **Created:** 4/16/2022 **Status:** ✅ Merged **Merged:** 4/20/2022 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `feat/loading-states` --- ### 📝 Commits (8) - [`2b5a3a6`](https://github.com/hoppscotch/hoppscotch/commit/2b5a3a67ded3c6f81c08591487fc1e735459e5f5) feat: add loading state to `CollectionsAdd` modal - [`e388eb4`](https://github.com/hoppscotch/hoppscotch/commit/e388eb4019fdf179fb148321e625a71072082225) feat: add loading state to `CollectionsEdit` modal - [`fe194e3`](https://github.com/hoppscotch/hoppscotch/commit/fe194e31225625569959fb633e2c0e933cb23b1c) feat: add loading state to `CollectionsAddFolder` modal - [`bb30e3d`](https://github.com/hoppscotch/hoppscotch/commit/bb30e3dc7d14a703be4af9ab2487b6935b55b5de) feat: add loading state to `CollectionsEditFolder` modal - [`d1b7637`](https://github.com/hoppscotch/hoppscotch/commit/d1b7637bc18c3161bdb70913f934d1de983cc65c) feat: add loading state to `CollectionsEditRequest` modal - [`695764f`](https://github.com/hoppscotch/hoppscotch/commit/695764fcd11447306b1ed590772ce9842f77fced) feat: add loading state to collection deletion - [`7632655`](https://github.com/hoppscotch/hoppscotch/commit/7632655fa7045571fc97499da3150f145aa970e7) feat: add loading state to request deletion - [`0f0cf31`](https://github.com/hoppscotch/hoppscotch/commit/0f0cf31b63fb747550f5757a50908a2de8bcef6e) feat: add loading state to folder deletion and other fixes ### 📊 Changes **13 files changed** (+242 additions, -177 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/components/collections/Add.vue` (+2 -1) 📝 `packages/hoppscotch-app/components/collections/AddFolder.vue` (+6 -2) 📝 `packages/hoppscotch-app/components/collections/Edit.vue` (+2 -1) 📝 `packages/hoppscotch-app/components/collections/EditFolder.vue` (+6 -2) 📝 `packages/hoppscotch-app/components/collections/EditRequest.vue` (+6 -2) 📝 `packages/hoppscotch-app/components/collections/index.vue` (+184 -33) 📝 `packages/hoppscotch-app/components/collections/my/Collection.vue` (+2 -9) 📝 `packages/hoppscotch-app/components/collections/my/Folder.vue` (+9 -39) 📝 `packages/hoppscotch-app/components/collections/my/Request.vue` (+1 -12) 📝 `packages/hoppscotch-app/components/collections/teams/Collection.vue` (+4 -18) 📝 `packages/hoppscotch-app/components/collections/teams/Folder.vue` (+8 -43) 📝 `packages/hoppscotch-app/components/collections/teams/Request.vue` (+3 -12) 📝 `packages/hoppscotch-app/components/smart/ConfirmModal.vue` (+9 -3) </details> ### 📄 Description ### Description Adds loading state to buttons in different modals. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>