mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[GH-ISSUE #1056] Web Socket query string params support #369
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#369
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Nsbx on GitHub (Aug 7, 2020).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/1056
Describe the bug
If you try to connect on one ws url with some query string params the button "connect" is disabled.
But if you edit the source code to remove the "disabled" html attribute and you click on "connect" this work perfectly.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The button shouldn't be disabled
The regex should probably be edited to accept query string params
Desktop (please complete the following information):
@liyasthomas commented on GitHub (Aug 7, 2020):
Can you tell which URL produced disabled "Connect" button? From my side, it looks okay even if there are multiple query string parameters used.
@Nsbx commented on GitHub (Aug 7, 2020):
I have the problem with an url of this type (this is fake domain and fake access_token)
wss://test.test.fr/?access_token=UQUhIlQ-ZLZlveQLYYmpuUl2U6qrllDGu5LIUUcUDVYg2P6glZotUEGgAlQdx6gO1l1KZoUUKOrl4aQQgelMKQ62aoMx2Umr5hQG2lk2rvuu_UllUAE8GQGU5G4L9pPmQAp77xkZqt7IMzgTlhlHCL4O2lUUQQiclxPayP2@liyasthomas commented on GitHub (Aug 7, 2020):
The last forward slash
/before query parameters is what causing the issue.Try this:
feel free to reopen this issue if it's not working.