[PR #2216] [MERGED] fix: add environment variables for OAuth2 #3677

New issue

Closed

opened 2026-03-17 01:16:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:16:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2216
Author: @ntarunmenon
Created: 3/31/2022
Status: ✅ Merged
Merged: 4/4/2022
Merged by: @liyasthomas

Base: main ← Head: 2113-Fix-oauth-variables

📝 Commits (4)

57ad649 fix: add environment variables for OAuth2
93de4d0 Merge branch 'main' into 2113-Fix-oauth-variables
00b3498 fix: proper imports for types
77fee80 Merge branch 'main' into 2113-Fix-oauth-variables

📊 Changes

3 files changed (+36 additions, -42 deletions)

View changed files

📝 packages/hoppscotch-app/components/http/OAuth2Authorization.vue (+31 -41)
📝 packages/hoppscotch-app/helpers/oauth.js (+4 -1)
📝 packages/hoppscotch-app/pages/index.vue (+1 -0)

📄 Description

Closes #2113

Description

Fixes environment variables not working in OAuth2.0
The post to get a token was failing because of client secret not being added. I had to add it in.
Tested by using google oAuth2 in my local.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

Since this is my first PR let me know if I am missing something. This PR will conflict with the client credentials PR that is already open. Happy to wait for that to get merged and I can merge with those changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2216 **Author:** [@ntarunmenon](https://github.com/ntarunmenon) **Created:** 3/31/2022 **Status:** ✅ Merged **Merged:** 4/4/2022 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `main` ← **Head:** `2113-Fix-oauth-variables` --- ### 📝 Commits (4) - [`57ad649`](https://github.com/hoppscotch/hoppscotch/commit/57ad6497d0d6e96e6c3b568a2c8b083f3a090e96) fix: add environment variables for OAuth2 - [`93de4d0`](https://github.com/hoppscotch/hoppscotch/commit/93de4d094182b421d7ccb4aaa91ae9bfb1691f10) Merge branch 'main' into 2113-Fix-oauth-variables - [`00b3498`](https://github.com/hoppscotch/hoppscotch/commit/00b3498be3af0937dcfc8a3ba0b042400ca56455) fix: proper imports for types - [`77fee80`](https://github.com/hoppscotch/hoppscotch/commit/77fee80fcedcf30d50e18d7f0c0822418cad77ec) Merge branch 'main' into 2113-Fix-oauth-variables ### 📊 Changes **3 files changed** (+36 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/components/http/OAuth2Authorization.vue` (+31 -41) 📝 `packages/hoppscotch-app/helpers/oauth.js` (+4 -1) 📝 `packages/hoppscotch-app/pages/index.vue` (+1 -0) </details> ### 📄 Description Closes #2113 ### Description - Fixes environment variables not working in OAuth2.0 - The post to get a token was failing because of client secret not being added. I had to add it in. - Tested by using google oAuth2 in my local.  ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [ ] All the tests have passed ### Additional Information Since this is my first PR let me know if I am missing something. This PR will conflict with the [client credentials PR](https://github.com/hoppscotch/hoppscotch/pull/2209) that is already open. Happy to wait for that to get merged and I can merge with those changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>