mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #2222] [MERGED] Prevent IMEs from triggering when editing a readonly code editor #3676
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#3676
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/2222
Author: @AndrewBastin
Created: 4/1/2022
Status: ✅ Merged
Merged: 4/1/2022
Merged by: @AndrewBastin
Base:
main← Head:fix/cm-readonly-ime📝 Commits (1)
e448b95fix: readonly codemirror fields don't trigger IMEs📊 Changes
1 file changed (+5 additions, -0 deletions)
View changed files
📝
packages/hoppscotch-app/helpers/editor/codemirror.ts(+5 -0)📄 Description
This small patch introduces a small update that blocks IMEs from starting composition when editing a readonly code editor instance.
This is especially useful on mobile devices where the virtual keyboard is triggered when the REST Response Body is tapped on which further reduces the screen space.
Checks
Additional Information
Check IME behavior on Android and iOS and see how they react on readonly and readwrite fields.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.