[PR #2104] [MERGED] feat: handle test script execution failure #3628

New issue

Closed

opened 2026-03-17 01:13:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:13:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2104
Author: @RishabhAgarwal-2001
Created: 1/31/2022
Status: ✅ Merged
Merged: 2/1/2022
Merged by: @liyasthomas

Base: main ← Head: main

📝 Commits (4)

951c155 feat: handle test script execution failure
ad04ab2 Merge branch 'main' into main
d567eb9 fix: make script error non optional
b27b111 Merge branch 'main' into main

📊 Changes

4 files changed (+33 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-app/components/http/TestResult.vue (+19 -0)
📝 packages/hoppscotch-app/helpers/RequestRunner.ts (+9 -1)
📝 packages/hoppscotch-app/helpers/types/HoppTestResult.ts (+1 -0)
📝 packages/hoppscotch-app/locales/en.json (+4 -2)

📄 Description

Closes #2079

Description

Existing code didn't handle the case when execution of test script was not successful. In case of a faulty test/post-request script, the users were greeted with the results of the latest valid test script.
With this PR, the case of script execution failure is now covered. Users will see an error message instead of old test results.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

N/A

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2104 **Author:** [@RishabhAgarwal-2001](https://github.com/RishabhAgarwal-2001) **Created:** 1/31/2022 **Status:** ✅ Merged **Merged:** 2/1/2022 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`951c155`](https://github.com/hoppscotch/hoppscotch/commit/951c15513a1355dab4e4230ebd65158e59ba2bcf) feat: handle test script execution failure - [`ad04ab2`](https://github.com/hoppscotch/hoppscotch/commit/ad04ab214be37925a657d0ee6250e2e33293d645) Merge branch 'main' into main - [`d567eb9`](https://github.com/hoppscotch/hoppscotch/commit/d567eb9f4e713fb5876120ccc989dfd1001ba4c2) fix: make script error non optional - [`b27b111`](https://github.com/hoppscotch/hoppscotch/commit/b27b1110a09396bd2200bcb67e58c1e120f88587) Merge branch 'main' into main ### 📊 Changes **4 files changed** (+33 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/components/http/TestResult.vue` (+19 -0) 📝 `packages/hoppscotch-app/helpers/RequestRunner.ts` (+9 -1) 📝 `packages/hoppscotch-app/helpers/types/HoppTestResult.ts` (+1 -0) 📝 `packages/hoppscotch-app/locales/en.json` (+4 -2) </details> ### 📄 Description   Closes #2079 ### Description Existing code didn't handle the case when execution of test script was not successful. In case of a faulty test/post-request script, the users were greeted with the results of the latest valid test script. With this PR, the case of script execution failure is now covered. Users will see an error message instead of old test results.  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information  N/A --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>