mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[GH-ISSUE #1025] [website] use svg instead of font-icons #360
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#360
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Jul 26, 2020).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/1025
Originally assigned to: @liyasthomas on GitHub.
not sure if that's a a bug report or a feature request, but it is existing and has negative impact, so its a bug.
not many places still use this technology, and for a good reason
@liyasthomas commented on GitHub (Jul 26, 2020):
Oops. I noticed this glitch on very first load of app. From second load onwards, icon font will be used from cache. I guess it's possible to replace icon font with SVGs since we're already using SVGs for some custom icons. But is there any other effective implementations?
I'm thinking of a native implementation around
font-displayproperty.Also I noticed probability of occurring such a delayed render is high with low-speed network.
@liyasthomas commented on GitHub (Aug 7, 2020):
@dym-sh Is this feature mandatory? I can't find any hard trouble with the initial 1 second delay for loading the icon font. This delay is not even noticeable after initial load because of pre-fetch and caching. If you insist I can work on a solution with SVG module.
cc: @AndrewBastin
@ghost commented on GitHub (Aug 7, 2020):
the problem is when 3rd-party fonts are disabled or unsupported – you'd get the thing on screenshot, no matter the delay
@ghost commented on GitHub (Aug 7, 2020):
im gonna try to solve this issue now, should not take too long
@AndrewBastin commented on GitHub (Aug 8, 2020):
Well, I think if we can get a proper implementation going, SVGs will be better than icon fonts.
Assigning to you @dym-sh !
@liyasthomas commented on GitHub (Aug 17, 2020):
@dym-sh if you're interested in working on this feature, I've made a working starting point for you. Checkout https://github.com/hoppscotch/hoppscotch/pull/1091 and follow the steps described in it to change remaining instances for icon font to svg icons.
Let me know if you've any doubts.