mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[PR #1870] [MERGED] feat: disable inputs in realtime and graphql connections when active #3536
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#3536
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/1870
Author: @blenderskool
Created: 10/12/2021
Status: ✅ Merged
Merged: 10/12/2021
Merged by: @liyasthomas
Base:
main← Head:realtime-inputs-disable📝 Commits (2)
18a2ea8feat: disable inputs of realtime, graphql requests once connected21e2e8cfix: input to which "event_type" label is associated with📊 Changes
5 files changed (+13 additions, -1 deletions)
View changed files
📝
packages/hoppscotch-app/components/graphql/Request.vue(+1 -0)📝
packages/hoppscotch-app/components/realtime/Mqtt.vue(+1 -0)📝
packages/hoppscotch-app/components/realtime/Socketio.vue(+7 -0)📝
packages/hoppscotch-app/components/realtime/Sse.vue(+3 -1)📝
packages/hoppscotch-app/components/realtime/Websocket.vue(+1 -0)📄 Description
The inputs in realtime and graphql requests which configure the initial connection are now disabled once the connection is established. When the connection closes, these inputs are enabled again.
This change has been made to the following types of requests:
I think it covers all the request types where the above behavior is observed. If I missed any, please let me know!
Additionally, I have fixed the
forattribute of a label that seemed to be pointing to an invalidinputtag. Let me know if the change was correct.github.com/blenderskool/hoppscotch@21e2e8cfba/packages/hoppscotch-app/components/realtime/Sse.vue (L35)Fixes #1869
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.