[PR #1870] [MERGED] feat: disable inputs in realtime and graphql connections when active #3536

Closed
opened 2026-03-17 01:08:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1870
Author: @blenderskool
Created: 10/12/2021
Status: Merged
Merged: 10/12/2021
Merged by: @liyasthomas

Base: mainHead: realtime-inputs-disable


📝 Commits (2)

  • 18a2ea8 feat: disable inputs of realtime, graphql requests once connected
  • 21e2e8c fix: input to which "event_type" label is associated with

📊 Changes

5 files changed (+13 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-app/components/graphql/Request.vue (+1 -0)
📝 packages/hoppscotch-app/components/realtime/Mqtt.vue (+1 -0)
📝 packages/hoppscotch-app/components/realtime/Socketio.vue (+7 -0)
📝 packages/hoppscotch-app/components/realtime/Sse.vue (+3 -1)
📝 packages/hoppscotch-app/components/realtime/Websocket.vue (+1 -0)

📄 Description

The inputs in realtime and graphql requests which configure the initial connection are now disabled once the connection is established. When the connection closes, these inputs are enabled again.
This change has been made to the following types of requests:

  • GraphQL
  • Realtime
    • WebSocket
    • SSE
    • Socket.io
    • MQTT

I think it covers all the request types where the above behavior is observed. If I missed any, please let me know!

Additionally, I have fixed the for attribute of a label that seemed to be pointing to an invalid input tag. Let me know if the change was correct.

github.com/blenderskool/hoppscotch@21e2e8cfba/packages/hoppscotch-app/components/realtime/Sse.vue (L35)

Fixes #1869


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1870 **Author:** [@blenderskool](https://github.com/blenderskool) **Created:** 10/12/2021 **Status:** ✅ Merged **Merged:** 10/12/2021 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `main` ← **Head:** `realtime-inputs-disable` --- ### 📝 Commits (2) - [`18a2ea8`](https://github.com/hoppscotch/hoppscotch/commit/18a2ea8d19cd2fe4904c77d21851fb9c04ecbde3) feat: disable inputs of realtime, graphql requests once connected - [`21e2e8c`](https://github.com/hoppscotch/hoppscotch/commit/21e2e8cfba506bd5e4d275b132af5756e9a63e41) fix: input to which "event_type" label is associated with ### 📊 Changes **5 files changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/components/graphql/Request.vue` (+1 -0) 📝 `packages/hoppscotch-app/components/realtime/Mqtt.vue` (+1 -0) 📝 `packages/hoppscotch-app/components/realtime/Socketio.vue` (+7 -0) 📝 `packages/hoppscotch-app/components/realtime/Sse.vue` (+3 -1) 📝 `packages/hoppscotch-app/components/realtime/Websocket.vue` (+1 -0) </details> ### 📄 Description The inputs in realtime and graphql requests which configure the initial connection are now disabled once the connection is established. When the connection closes, these inputs are enabled again. This change has been made to the following types of requests: - GraphQL - Realtime - WebSocket - SSE - Socket.io - MQTT I think it covers all the request types where the above behavior is observed. If I missed any, please let me know! Additionally, I have fixed the `for` attribute of a label that seemed to be pointing to an invalid `input` tag. Let me know if the change was correct. https://github.com/blenderskool/hoppscotch/blob/21e2e8cfba506bd5e4d275b132af5756e9a63e41/packages/hoppscotch-app/components/realtime/Sse.vue#L35 _Fixes #1869_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:08:39 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#3536
No description provided.