[PR #1852] [MERGED] Show graphql error message #3523

New issue

Closed

opened 2026-03-17 01:07:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:07:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1852
Author: @StephaneBischoff
Created: 10/3/2021
Status: ✅ Merged
Merged: 10/4/2021
Merged by: @liyasthomas

Base: main ← Head: main

📝 Commits (5)

490abc6 feat: show error message for graphql
6d17eee feat: added tests and improved layout
f8fde62 Merge branch 'main' into main
bc08922 refactor: minor ui improvements
9e40ab7 Update packages/hoppscotch-app/components/graphql/RequestOptions.vue

📊 Changes

4 files changed (+38 additions, -11 deletions)

View changed files

📝 packages/hoppscotch-app/components/graphql/RequestOptions.vue (+7 -4)
📝 packages/hoppscotch-app/helpers/strategies/AxiosStrategy.js (+5 -3)
📝 packages/hoppscotch-app/helpers/strategies/__tests__/AxiosStrategy-NoProxy.spec.js (+21 -4)
➕ packages/hoppscotch-app/helpers/utils/JsonFormattedError.ts (+5 -0)

📄 Description

Fix proposal (very simple) for request #1828

I was not clear from the original ticket what the requirements were.

Like the toast message format might not be ideal. Maybe could indicate that it was a HTTP 400 error for example instead of the entire error message.
Also, should we continue to say to go and check the logs for futher details?
I did not test with proxies. Seems like the request made is different in that case. (not using responseType: "arraybuffer"

Let me know what you think. thanks

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1852 **Author:** [@StephaneBischoff](https://github.com/StephaneBischoff) **Created:** 10/3/2021 **Status:** ✅ Merged **Merged:** 10/4/2021 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (5) - [`490abc6`](https://github.com/hoppscotch/hoppscotch/commit/490abc631dd91084c71e6510ca2f75b63e46e18b) feat: show error message for graphql - [`6d17eee`](https://github.com/hoppscotch/hoppscotch/commit/6d17eeef0445407008690586291ac2a801b4ca92) feat: added tests and improved layout - [`f8fde62`](https://github.com/hoppscotch/hoppscotch/commit/f8fde629db964a2985f75e227392e0663867044a) Merge branch 'main' into main - [`bc08922`](https://github.com/hoppscotch/hoppscotch/commit/bc08922a8eec2a18ce0c65583cce079202ad6302) refactor: minor ui improvements - [`9e40ab7`](https://github.com/hoppscotch/hoppscotch/commit/9e40ab7b37028bc18eda41f0adca03cc8d860074) Update packages/hoppscotch-app/components/graphql/RequestOptions.vue ### 📊 Changes **4 files changed** (+38 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/components/graphql/RequestOptions.vue` (+7 -4) 📝 `packages/hoppscotch-app/helpers/strategies/AxiosStrategy.js` (+5 -3) 📝 `packages/hoppscotch-app/helpers/strategies/__tests__/AxiosStrategy-NoProxy.spec.js` (+21 -4) ➕ `packages/hoppscotch-app/helpers/utils/JsonFormattedError.ts` (+5 -0) </details> ### 📄 Description Fix proposal (very simple) for request #1828 I was not clear from the original ticket what the requirements were. - Like the toast message format might not be ideal. Maybe could indicate that it was a HTTP 400 error for example instead of the entire error message. - Also, should we continue to say to go and check the logs for futher details? - I did not test with proxies. Seems like the request made is different in that case. (not using `responseType: "arraybuffer"` Let me know what you think. thanks ![error-message](https://user-images.githubusercontent.com/9750058/135760952-98517338-1bbd-4407-a600-93f0fb761a20.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>