[PR #1769] [MERGED] fix: broken settings persistence on the home page #3484

New issue

Closed

opened 2026-03-17 01:05:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:05:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1769
Author: @s-r-x
Created: 8/9/2021
Status: ✅ Merged
Merged: 8/9/2021
Merged by: @AndrewBastin

Base: main ← Head: fix/settings-persistence

📝 Commits (2)

6aa6fb5 fix: broken settings persistence
058c109 fix: remove settings entries from postwoman.js

📊 Changes

2 files changed (+25 additions, -87 deletions)

View changed files

📝 newstore/localpersistence.ts (+25 -18)
📝 store/postwoman.js (+0 -69)

📄 Description

The problem:
https://user-images.githubusercontent.com/41614937/128659587-6ebd297b-7f61-4db1-bf04-41c47e4d76f9.mp4

This line always returns true since vuexData.postwoman.settings is an object(somehow)
This one also always returns true because we are using shallow comparison for different objects, so _.isEmpty is a better choice here.
I don't fully understand the background of these migrations, but i took responsibility to refactor this file a little bit(the postwoman part of it), looks like it shouldn't break anything

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1769 **Author:** [@s-r-x](https://github.com/s-r-x) **Created:** 8/9/2021 **Status:** ✅ Merged **Merged:** 8/9/2021 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `fix/settings-persistence` --- ### 📝 Commits (2) - [`6aa6fb5`](https://github.com/hoppscotch/hoppscotch/commit/6aa6fb5c0abae50153ec3cacf5e822231bebe2b0) fix: broken settings persistence - [`058c109`](https://github.com/hoppscotch/hoppscotch/commit/058c1090e3c94f6464fc34a12aebb3442e4360b0) fix: remove settings entries from postwoman.js ### 📊 Changes **2 files changed** (+25 additions, -87 deletions) <details> <summary>View changed files</summary> 📝 `newstore/localpersistence.ts` (+25 -18) 📝 `store/postwoman.js` (+0 -69) </details> ### 📄 Description The problem: https://user-images.githubusercontent.com/41614937/128659587-6ebd297b-7f61-4db1-bf04-41c47e4d76f9.mp4 [This line](https://github.com/hoppscotch/hoppscotch/blob/main/newstore/localpersistence.ts#L32) always returns true since vuexData.postwoman.settings is an object(somehow) [This one](https://github.com/hoppscotch/hoppscotch/blob/main/newstore/localpersistence.ts#L30) also always returns true because we are using shallow comparison for different objects, so _.isEmpty is a better choice here. I don't fully understand the background of these migrations, but i took responsibility to refactor this file a little bit(the postwoman part of it), looks like it shouldn't break anything --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>