[PR #1763] [CLOSED] Add the notranslate classes #3480

Closed
opened 2026-03-17 01:05:21 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1763
Author: @ghost
Created: 8/6/2021
Status: Closed

Base: mainHead: fix/material-icons


📝 Commits (2)

  • 7c4532a Add the notranslate classes
  • 5e4099e Merge branch 'main' into fix/material-icons

📊 Changes

77 files changed (+352 additions, -299 deletions)

View changed files

📝 components/app/Extensions.vue (+5 -5)
📝 components/app/Footer.vue (+2 -2)
📝 components/app/Header.vue (+10 -10)
📝 components/app/Section.vue (+1 -1)
📝 components/app/Shortcuts.vue (+1 -1)
📝 components/app/Sidenav.vue (+5 -5)
📝 components/collections/Add.vue (+1 -1)
📝 components/collections/AddFolder.vue (+1 -1)
📝 components/collections/Edit.vue (+1 -1)
📝 components/collections/EditFolder.vue (+1 -1)
📝 components/collections/EditRequest.vue (+1 -1)
📝 components/collections/ImportExport.vue (+10 -10)
📝 components/collections/SaveRequest.vue (+1 -1)
📝 components/collections/graphql/Add.vue (+1 -1)
📝 components/collections/graphql/AddFolder.vue (+1 -1)
📝 components/collections/graphql/Collection.vue (+15 -9)
📝 components/collections/graphql/Edit.vue (+1 -1)
📝 components/collections/graphql/EditFolder.vue (+1 -1)
📝 components/collections/graphql/EditRequest.vue (+1 -1)
📝 components/collections/graphql/Folder.vue (+14 -8)

...and 57 more files

📄 Description

Hello,
when I auto translated the website, I have found a bug.


Problem description

Material Icons crashed user interface when user wanted to auto translate the website.


Preferred solution

I have added the notranslate class to all elements with the material-icons class.


Screenshot

I leave below screenshot without and with the notranslate classes.

Without

With


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1763 **Author:** [@ghost](https://github.com/ghost) **Created:** 8/6/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/material-icons` --- ### 📝 Commits (2) - [`7c4532a`](https://github.com/hoppscotch/hoppscotch/commit/7c4532a348c534b95ce082c2eab4267ce07bd483) Add the `notranslate` classes - [`5e4099e`](https://github.com/hoppscotch/hoppscotch/commit/5e4099eab22929d77ddf32ad8f5ed0546236e4bc) Merge branch 'main' into fix/material-icons ### 📊 Changes **77 files changed** (+352 additions, -299 deletions) <details> <summary>View changed files</summary> 📝 `components/app/Extensions.vue` (+5 -5) 📝 `components/app/Footer.vue` (+2 -2) 📝 `components/app/Header.vue` (+10 -10) 📝 `components/app/Section.vue` (+1 -1) 📝 `components/app/Shortcuts.vue` (+1 -1) 📝 `components/app/Sidenav.vue` (+5 -5) 📝 `components/collections/Add.vue` (+1 -1) 📝 `components/collections/AddFolder.vue` (+1 -1) 📝 `components/collections/Edit.vue` (+1 -1) 📝 `components/collections/EditFolder.vue` (+1 -1) 📝 `components/collections/EditRequest.vue` (+1 -1) 📝 `components/collections/ImportExport.vue` (+10 -10) 📝 `components/collections/SaveRequest.vue` (+1 -1) 📝 `components/collections/graphql/Add.vue` (+1 -1) 📝 `components/collections/graphql/AddFolder.vue` (+1 -1) 📝 `components/collections/graphql/Collection.vue` (+15 -9) 📝 `components/collections/graphql/Edit.vue` (+1 -1) 📝 `components/collections/graphql/EditFolder.vue` (+1 -1) 📝 `components/collections/graphql/EditRequest.vue` (+1 -1) 📝 `components/collections/graphql/Folder.vue` (+14 -8) _...and 57 more files_ </details> ### 📄 Description Hello, when I auto translated the website, I have found a bug. --- ## Problem description Material Icons crashed user interface when user wanted to auto translate the website. --- ## Preferred solution I have added the `notranslate` class to all elements with the `material-icons` class. --- ## Screenshot I leave below screenshot without and with the `notranslate` classes. ![Without](https://user-images.githubusercontent.com/64834645/128548216-61a1934e-e05b-4ba3-8ab8-57d3197ec70e.png) ![With](https://user-images.githubusercontent.com/64834645/128551326-c9bf2c2f-4daf-4533-849f-07b99d68a3d4.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:05:21 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#3480
No description provided.