[PR #1737] [MERGED] fix: duplicated input ids #3472

Closed
opened 2026-03-17 01:05:04 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1737
Author: @s-r-x
Created: 7/1/2021
Status: Merged
Merged: 7/1/2021
Merged by: @liyasthomas

Base: mainHead: fix/duplicate-input-id


📝 Commits (1)

  • 47cf321 fix: duplicated input ids

📊 Changes

13 files changed (+27 additions, -27 deletions)

View changed files

📝 components/collections/Add.vue (+2 -2)
📝 components/collections/AddFolder.vue (+2 -2)
📝 components/collections/Edit.vue (+2 -2)
📝 components/collections/EditFolder.vue (+2 -2)
📝 components/collections/EditRequest.vue (+2 -2)
📝 components/collections/SaveRequest.vue (+3 -3)
📝 components/collections/graphql/Add.vue (+2 -2)
📝 components/collections/graphql/AddFolder.vue (+2 -2)
📝 components/collections/graphql/Edit.vue (+2 -2)
📝 components/collections/graphql/EditFolder.vue (+2 -2)
📝 components/collections/graphql/EditRequest.vue (+2 -2)
📝 components/environments/Add.vue (+2 -2)
📝 components/environments/Edit.vue (+2 -2)

📄 Description

There are some duplicated inputs' ids on the page.
To reproduce:

  • click "save to collections"(gql or home page - that's doesn't matter) and check out the id of the "Request name" input.
  • click "new" and compare the "Label" input id with the one from the first step. they are the same.
    Sometimes duplicated ids can lead to some really weird behavior. in this case if you click on the label from the second step - input from the first one gets focused.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1737 **Author:** [@s-r-x](https://github.com/s-r-x) **Created:** 7/1/2021 **Status:** ✅ Merged **Merged:** 7/1/2021 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `main` ← **Head:** `fix/duplicate-input-id` --- ### 📝 Commits (1) - [`47cf321`](https://github.com/hoppscotch/hoppscotch/commit/47cf321eba14a27a866dd7a5d9a676ded66f7258) fix: duplicated input ids ### 📊 Changes **13 files changed** (+27 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `components/collections/Add.vue` (+2 -2) 📝 `components/collections/AddFolder.vue` (+2 -2) 📝 `components/collections/Edit.vue` (+2 -2) 📝 `components/collections/EditFolder.vue` (+2 -2) 📝 `components/collections/EditRequest.vue` (+2 -2) 📝 `components/collections/SaveRequest.vue` (+3 -3) 📝 `components/collections/graphql/Add.vue` (+2 -2) 📝 `components/collections/graphql/AddFolder.vue` (+2 -2) 📝 `components/collections/graphql/Edit.vue` (+2 -2) 📝 `components/collections/graphql/EditFolder.vue` (+2 -2) 📝 `components/collections/graphql/EditRequest.vue` (+2 -2) 📝 `components/environments/Add.vue` (+2 -2) 📝 `components/environments/Edit.vue` (+2 -2) </details> ### 📄 Description There are some duplicated inputs' ids on the page. To reproduce: - click "save to collections"(gql or home page - that's doesn't matter) and check out the id of the "Request name" input. - click "new" and compare the "Label" input id with the one from the first step. they are the same. Sometimes duplicated ids can lead to some really weird behavior. in this case if you click on the label from the second step - input from the first one gets focused. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:05:04 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#3472
No description provided.