[PR #1567] [CLOSED] Refactor pages/index.vue #3401

Closed
opened 2026-03-17 01:01:14 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1567
Author: @oshhh
Created: 3/28/2021
Status: Closed

Base: mainHead: refactor-index


📝 Commits (10+)

📊 Changes

4 files changed (+431 additions, -504 deletions)

View changed files

📝 components/http/BodyParameters.vue (+27 -25)
📝 newstore/settings.ts (+14 -5)
📝 pages/index.vue (+379 -471)
📝 store/mutations.js (+11 -3)

📄 Description

Changes:
Encapsulated name, method, auth, etc into request variable.
Encapsulated token, tokenReqs, etc into oauth2 variable.

Testing:
Done manually before every commit.

Checks:

  • Remove unused variables / imports (fs) / console logs
    • This should fix LGTM warnings
  • Re-introduce URL_EXCLUDES in setRouteQuery()
    • This should fix broken "populate URL parameters while reloading Hoppscotch URL" + share request by URL.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1567 **Author:** [@oshhh](https://github.com/oshhh) **Created:** 3/28/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `refactor-index` --- ### 📝 Commits (10+) - [`0acd4de`](https://github.com/hoppscotch/hoppscotch/commit/0acd4de1276a48ea3f79c6c5b5c8686c58f446b3) Create REQUIREMENTS.md - [`5496bd0`](https://github.com/hoppscotch/hoppscotch/commit/5496bd0f9d78f75e06666ca677b09c94cacc71b3) Merge branch 'main' of github.com:hoppscotch/hoppscotch - [`c1bc8f6`](https://github.com/hoppscotch/hoppscotch/commit/c1bc8f62b94f6702d487eebd352bd5cd59678f3c) Merge branch 'main' of https://github.com/hoppscotch/hoppscotch into main - [`d576114`](https://github.com/hoppscotch/hoppscotch/commit/d576114c9e1a7e121ba3043addde03fd4216fb01) Merge branch 'main' of https://github.com/hoppscotch/hoppscotch into main - [`3b62e46`](https://github.com/hoppscotch/hoppscotch/commit/3b62e4645664c710f79ec69358c49e054783e15a) Merge branch 'main' of github.com:hoppscotch/hoppscotch - [`5bb77ee`](https://github.com/hoppscotch/hoppscotch/commit/5bb77ee77ffe8f710af7a9b19d06d3d6a652861f) name, method => request - [`765195a`](https://github.com/hoppscotch/hoppscotch/commit/765195acf98251149ac0bb3e69068405c7a00938) auth => request - [`684325f`](https://github.com/hoppscotch/hoppscotch/commit/684325fc1a2590ffc74ad98e781ce2dc0a43d51f) httpUser, httpPassword => request - [`9a053d0`](https://github.com/hoppscotch/hoppscotch/commit/9a053d0d9db874a52ffddd97477097d88ad55a93) bearerToken, tokens => request - [`79351ee`](https://github.com/hoppscotch/hoppscotch/commit/79351ee327dd7e524ba1158ff392b6810d5e5017) tokens, tokenReqs, tokenReqSelect, tokenReqName, accessTokenName, oidcDiscoveryUrl, authUrl, accessTokenUrl, clientId, scope => oauth2 ### 📊 Changes **4 files changed** (+431 additions, -504 deletions) <details> <summary>View changed files</summary> 📝 `components/http/BodyParameters.vue` (+27 -25) 📝 `newstore/settings.ts` (+14 -5) 📝 `pages/index.vue` (+379 -471) 📝 `store/mutations.js` (+11 -3) </details> ### 📄 Description **Changes:** Encapsulated name, method, auth, etc into `request` variable. Encapsulated token, tokenReqs, etc into `oauth2` variable. **Testing:** Done manually before every commit. **Checks:** - [x] Remove unused variables / imports (fs) / console logs - [x] This should fix LGTM warnings - [x] Re-introduce `URL_EXCLUDES` in `setRouteQuery()` - [x] This should fix broken "populate URL parameters while reloading Hoppscotch URL" + share request by URL. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:01:15 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#3401
No description provided.