[PR #1560] [MERGED] Revamp of the Settings State System along with TypeScript support #3398

New issue

Closed

opened 2026-03-17 01:00:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:00:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1560
Author: @AndrewBastin
Created: 3/23/2021
Status: ✅ Merged
Merged: 3/23/2021
Merged by: @AndrewBastin

Base: main ← Head: refactor/newstore-settings

📝 Commits (10+)

3b894c0 Add vue-rx, rxjs and lodash as dependencies
b49970e Added vue-rx plugin integration to nuxt config
93f91d7 Initial settings store implementation
1df5e04 Add babel plugin for private class properties to for Jest
5bf6b3a Add DispatchingStore test spec
c860fa6 Initial settings code
57d274a Reactive Streams for fb current user and id token
2d98988 Fix typo
d141316 Migrate index and graphql pages to the new store
a896485 Migrate network strategy to the new store

📊 Changes

47 files changed (+35999 additions, -12716 deletions)

View changed files

📝 babel.config.js (+3 -0)
📝 components/app/Section.vue (+7 -6)
📝 components/collections/Add.vue (+11 -7)
📝 components/collections/Collection.vue (+11 -7)
📝 components/collections/Edit.vue (+11 -7)
📝 components/collections/EditFolder.vue (+11 -7)
📝 components/collections/EditRequest.vue (+11 -7)
📝 components/collections/Folder.vue (+11 -7)
📝 components/collections/ImportExport.vue (+9 -7)
📝 components/collections/Request.vue (+11 -7)
📝 components/collections/SaveRequest.vue (+11 -7)
📝 components/collections/index.vue (+11 -7)
📝 components/environments/Add.vue (+8 -4)
📝 components/environments/Edit.vue (+8 -4)
📝 components/environments/Environment.vue (+8 -4)
📝 components/environments/ImportExport.vue (+8 -4)
📝 components/environments/index.vue (+8 -4)
➖ helpers/__tests__/fb.spec.js (+0 -1252)
➕ helpers/__tests__/network-ExtDisabled.spec.js (+83 -0)
➕ helpers/__tests__/network-ExtEnabled.spec.js (+82 -0)

...and 27 more files

📄 Description

This PR brings forth the following new additions

vue-rx support for components
New Store system set to eventually replace Vuex powered by RxJS Observables and Subjects
TypeScript support via nuxt-typescript
Porting the Settings page and Section component to TypeScript as reference for TypeScript implementation
Addition of ts-jest to test TypeScript test specs and TypeScript source files
Removal of fb.spec.js due to the brittleness of the test spec.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1560 **Author:** [@AndrewBastin](https://github.com/AndrewBastin) **Created:** 3/23/2021 **Status:** ✅ Merged **Merged:** 3/23/2021 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `refactor/newstore-settings` --- ### 📝 Commits (10+) - [`3b894c0`](https://github.com/hoppscotch/hoppscotch/commit/3b894c0b56d0a292651c32a9585180cfa032ec65) Add vue-rx, rxjs and lodash as dependencies - [`b49970e`](https://github.com/hoppscotch/hoppscotch/commit/b49970e61c22978f012b3f2009a2e4d93365aafd) Added vue-rx plugin integration to nuxt config - [`93f91d7`](https://github.com/hoppscotch/hoppscotch/commit/93f91d7b0a852bcd7e45891452966117813d6e45) Initial settings store implementation - [`1df5e04`](https://github.com/hoppscotch/hoppscotch/commit/1df5e041869cfd3f0e2396c243c0af0316482acf) Add babel plugin for private class properties to for Jest - [`5bf6b3a`](https://github.com/hoppscotch/hoppscotch/commit/5bf6b3a3452d85b3ac6d3be6623c60c0fe22a8fe) Add DispatchingStore test spec - [`c860fa6`](https://github.com/hoppscotch/hoppscotch/commit/c860fa684e50498250f2c57fde4fc7f876452f84) Initial settings code - [`57d274a`](https://github.com/hoppscotch/hoppscotch/commit/57d274ae4e44d53e0a675c970dff831526fefa56) Reactive Streams for fb current user and id token - [`2d98988`](https://github.com/hoppscotch/hoppscotch/commit/2d98988ea929654712117471a97794107e9f19ea) Fix typo - [`d141316`](https://github.com/hoppscotch/hoppscotch/commit/d14131668528e7646cf9e4cca47bdcf7fd0f821c) Migrate index and graphql pages to the new store - [`a896485`](https://github.com/hoppscotch/hoppscotch/commit/a896485f1abb46e18a7ff9ddad378f5a6ed89d1f) Migrate network strategy to the new store ### 📊 Changes **47 files changed** (+35999 additions, -12716 deletions) <details> <summary>View changed files</summary> 📝 `babel.config.js` (+3 -0) 📝 `components/app/Section.vue` (+7 -6) 📝 `components/collections/Add.vue` (+11 -7) 📝 `components/collections/Collection.vue` (+11 -7) 📝 `components/collections/Edit.vue` (+11 -7) 📝 `components/collections/EditFolder.vue` (+11 -7) 📝 `components/collections/EditRequest.vue` (+11 -7) 📝 `components/collections/Folder.vue` (+11 -7) 📝 `components/collections/ImportExport.vue` (+9 -7) 📝 `components/collections/Request.vue` (+11 -7) 📝 `components/collections/SaveRequest.vue` (+11 -7) 📝 `components/collections/index.vue` (+11 -7) 📝 `components/environments/Add.vue` (+8 -4) 📝 `components/environments/Edit.vue` (+8 -4) 📝 `components/environments/Environment.vue` (+8 -4) 📝 `components/environments/ImportExport.vue` (+8 -4) 📝 `components/environments/index.vue` (+8 -4) ➖ `helpers/__tests__/fb.spec.js` (+0 -1252) ➕ `helpers/__tests__/network-ExtDisabled.spec.js` (+83 -0) ➕ `helpers/__tests__/network-ExtEnabled.spec.js` (+82 -0) _...and 27 more files_ </details> ### 📄 Description This PR brings forth the following new additions - [vue-rx](https://github.com/vuejs/vue-rx) support for components - New Store system set to eventually replace [Vuex](https://vuex.vuejs.org/) powered by [RxJS](https://rxjs-dev.firebaseapp.com/) Observables and Subjects - [TypeScript](https://www.typescriptlang.org/) support via [nuxt-typescript](https://typescript.nuxtjs.org/) - Porting the Settings page and Section component to TypeScript as reference for TypeScript implementation - Addition of [ts-jest](https://github.com/kulshekhar/ts-jest) to test TypeScript test specs and TypeScript source files - Removal of `fb.spec.js` due to the brittleness of the test spec. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>