[PR #1523] [MERGED] [Feat:Teams] Code restructure [3] and bug fixes #3372

New issue

Closed

opened 2026-03-17 00:59:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:59:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1523
Author: @oshhh
Created: 3/1/2021
Status: ✅ Merged
Merged: 3/2/2021
Merged by: @liyasthomas

Base: feat/teams-new-ui ← Head: feat/teams-new-ui

📝 Commits (8)

9891a61 Merge pull request #8 from SDOS-Winter2021/feat/teams-new-ui-isha-folder
514841f shift team create edit delete to utils
00cabb9 exit team
7ee26dc exit team
b44aacb update-team-collections on add edit delete
b881d73 Merge pull request #9 from SDOS-Winter2021/feat/teams-new-ui-osheen
85fc8b9 exit team bug
0273372 removed unused variable

📊 Changes

10 files changed (+119 additions, -116 deletions)

View changed files

📝 components/collections/collection.vue (+3 -1)
📝 components/collections/edit-collection.vue (+2 -17)
📝 components/collections/edit-folder.vue (+1 -1)
📝 components/collections/folder.vue (+3 -1)
📝 components/collections/index.vue (+2 -1)
📝 components/teams/add-team.vue (+2 -17)
📝 components/teams/edit-team.vue (+3 -35)
📝 components/teams/team.vue (+5 -18)
📝 helpers/teams/utils.js (+97 -25)
📝 layouts/default.vue (+1 -0)

📄 Description

Changes:

Finished all remaining code restructure regarding shifting all code to helpers/teams/utils.js.
Update team collections on add, delete folders.

Remaining Changes:

On updateTeamCollections after add, delete folder, only root collections are fetched. Fetch complete nested collections after addition of such a backend function.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1523 **Author:** [@oshhh](https://github.com/oshhh) **Created:** 3/1/2021 **Status:** ✅ Merged **Merged:** 3/2/2021 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `feat/teams-new-ui` ← **Head:** `feat/teams-new-ui` --- ### 📝 Commits (8) - [`9891a61`](https://github.com/hoppscotch/hoppscotch/commit/9891a61fcbcdb82c8af49853208a0f01dc0cfff8) Merge pull request #8 from SDOS-Winter2021/feat/teams-new-ui-isha-folder - [`514841f`](https://github.com/hoppscotch/hoppscotch/commit/514841f54efb0faa67452076a738b9685507b262) shift team create edit delete to utils - [`00cabb9`](https://github.com/hoppscotch/hoppscotch/commit/00cabb937e4ccfd011c4eb3d3530c11d70768b96) exit team - [`7ee26dc`](https://github.com/hoppscotch/hoppscotch/commit/7ee26dc8d8d0ebb7c3fc92a18d3f349d87e3bc8a) exit team - [`b44aacb`](https://github.com/hoppscotch/hoppscotch/commit/b44aacb4d8d2095b19446610ad209a6fc1030db5) update-team-collections on add edit delete - [`b881d73`](https://github.com/hoppscotch/hoppscotch/commit/b881d7326aea68eaa56dd4868bd4558277a58333) Merge pull request #9 from SDOS-Winter2021/feat/teams-new-ui-osheen - [`85fc8b9`](https://github.com/hoppscotch/hoppscotch/commit/85fc8b9fd9915530462afaa70a035719ed628acd) exit team bug - [`0273372`](https://github.com/hoppscotch/hoppscotch/commit/0273372863cbb034fc13a12239903fa222c6e775) removed unused variable ### 📊 Changes **10 files changed** (+119 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `components/collections/collection.vue` (+3 -1) 📝 `components/collections/edit-collection.vue` (+2 -17) 📝 `components/collections/edit-folder.vue` (+1 -1) 📝 `components/collections/folder.vue` (+3 -1) 📝 `components/collections/index.vue` (+2 -1) 📝 `components/teams/add-team.vue` (+2 -17) 📝 `components/teams/edit-team.vue` (+3 -35) 📝 `components/teams/team.vue` (+5 -18) 📝 `helpers/teams/utils.js` (+97 -25) 📝 `layouts/default.vue` (+1 -0) </details> ### 📄 Description **Changes:** * Finished all remaining code restructure regarding shifting all code to `helpers/teams/utils.js`. * Update team collections on add, delete folders. **Remaining Changes:** * On updateTeamCollections after add, delete folder, only root collections are fetched. Fetch complete nested collections after addition of such a backend function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>