[PR #1453] [CLOSED] fixed path parameter encoding and URL updation #3318

New issue

Closed

opened 2026-03-17 00:56:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:56:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1453
Author: @oshhh
Created: 1/29/2021
Status: ❌ Closed

Base: main ← Head: bug_fixes

📝 Commits (4)

3f43cdc fixed path parameter encoding
270141a fixed path parameter decoding and updation
e2728ad removed debugging print
692bb83 fixed url and uri dependancy

📊 Changes

3 files changed (+12 additions, -15 deletions)

View changed files

📝 helpers/templating.js (+2 -1)
📝 pages/index.vue (+9 -13)
📝 store/state.js (+1 -1)

📄 Description

Changed the parseTemplateString function. new URL(string).toString() would take care of bad format URLs instead of calling encodeURI explicitly as was done in this commit to ensure double encoding doesn't occur on the URLs.

Also changed the way updation happens for URLs. On getting a URL, I am regenerating it from the URI and parameters instead of creating it in advance. Creating in advance is an issue when the parameter values are changed as mentioned in issue #1452

Solves #1451 #1452

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1453 **Author:** [@oshhh](https://github.com/oshhh) **Created:** 1/29/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bug_fixes` --- ### 📝 Commits (4) - [`3f43cdc`](https://github.com/hoppscotch/hoppscotch/commit/3f43cdc01808c5298dc8b4c8ef7a053fc36eae2a) fixed path parameter encoding - [`270141a`](https://github.com/hoppscotch/hoppscotch/commit/270141ad471445bf1408831dcf1644c6f5cd62ad) fixed path parameter decoding and updation - [`e2728ad`](https://github.com/hoppscotch/hoppscotch/commit/e2728ad83ce5fbf20f01145d327787f7023090bc) removed debugging print - [`692bb83`](https://github.com/hoppscotch/hoppscotch/commit/692bb831c15d343d8b398c10642e59272ff6b074) fixed url and uri dependancy ### 📊 Changes **3 files changed** (+12 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `helpers/templating.js` (+2 -1) 📝 `pages/index.vue` (+9 -13) 📝 `store/state.js` (+1 -1) </details> ### 📄 Description Changed the parseTemplateString function. new URL(string).toString() would take care of bad format URLs instead of calling encodeURI explicitly as was done in this [commit](https://github.com/hoppscotch/hoppscotch/commit/9ac0cf140657167974d7b8b7015c851347139dcd#diff-ed425e40c260457bd7cafb88cf0ddc51b1895c787b93dc81c6fc31bf9496f911) to ensure double encoding doesn't occur on the URLs. Also changed the way updation happens for URLs. On getting a URL, I am regenerating it from the URI and parameters instead of creating it in advance. Creating in advance is an issue when the parameter values are changed as mentioned in issue #1452 Solves #1451 #1452 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>